Skip to content
Open

Develop #4533

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
module.exports = {
extends: '@mate-academy/eslint-config',
parser: "babel-eslint",
env: {
jest: true
},
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:

strategy:
matrix:
node-version: [12.x]
node-version: [20.x]

steps:
- uses: actions/checkout@v2
Expand Down
3 changes: 3 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
/node_modules
/dist
**/*.test.js
8 changes: 8 additions & 0 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"tabWidth": 2,
"useTabs": false,
"semi": true,
"singleQuote": true,
"trailingComma": "all",
"printWidth": 80
}
3 changes: 0 additions & 3 deletions babel.config.js

This file was deleted.

5 changes: 2 additions & 3 deletions checklist.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
1. [CODE KNOWLEDGE] When you are using indexOf and splice combo - you should check if element was found before deleting element.
2. [CODE PERFOMANCE] - Try to avoid nesting loops (indexOf + splice), use filter instead
3. [FUNCTION NAMING] - if the function has a name hide this function should just hide but not toggle
1. [CODE PERFOMANCE] - Try to avoid nesting loops (indexOf + splice), use filter instead
2. [FUNCTION NAMING] - if a method's name is `hide` - this method should just hide(set `true` to the object's `hidden` property) but not toggle the property's value
Loading