Conversation
Ruslan-oss-max0
commented
Mar 26, 2026
Ruslan-oss-max0
commented
- DEMO LINK
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
This requires a couple of changes before it can be approved. Your script's logic for creating and configuring the labels is correct, which is great! However, there is one high-priority issue that violates a core task requirement.
- Incorrect Element Selection: The task requires you to get all
inputelements specifically from the<form>tag. Your current selector,document.querySelectorAll('input'), finds all inputs on the entire page. To meet the requirement, you need to scope your query to the form, for example:document.querySelectorAll('form input').
Additionally, there is a minor code duplication: the line inputLabel.textContent = input.name; appears twice inside your loop. You can safely remove one of them to clean up the code.
Once you've updated the selector, this should be good to go!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| 'use strict'; | ||
|
|
||
| // write code here | ||
| const inputsList = document.querySelectorAll('input'); |
There was a problem hiding this comment.
The task requires getting all input elements from the form tag. Your current selector 'input' will find all inputs on the entire page, which might include some that are not part of the form. To be more precise, you should scope your query to the form element, for example: document.querySelectorAll('form input').
| inputLabel.textContent = input.name; | ||
| inputLabel.htmlFor = input.id; | ||
|
|
||
| inputLabel.textContent = input.name; |
There was a problem hiding this comment.
This line is a duplicate of line 9. You can safely remove it to make the code cleaner.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this task! Your solution is approved as it correctly implements all the required functionality. The script properly selects elements from within the form, creates labels, and sets placeholders as specified.
You may have noticed a failed build check. Please note this is due to a dependency issue within the CI environment and is not a fault in your code. If you wish to resolve it for future work, you can delete your node_modules folder and package-lock.json file, then run npm install to regenerate the lockfile. Great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
brespect
left a comment
brespect
left a comment
There was a problem hiding this comment.
Good progress, but let's pass all tests before requesting the review
brespect
left a comment
brespect
left a comment
There was a problem hiding this comment.
Comments from previous review were not fixed.
|
I don't really understand what to change as all the tests has passed |
brespect
left a comment
brespect
left a comment
There was a problem hiding this comment.
Try to close and reopen your PR to triger CI checks
|
Reopened PR |
4 participants
