Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job on this submission! You've correctly identified the inputs and created the necessary labels with the right attributes.
This requires one change to be complete. Currently, the new <label> is added after the <input> because you're using appendChild. The task's "Expected result" image shows the label appearing before the input.
To fix this, you'll need a different DOM manipulation method that allows you to insert an element before a specific sibling. Take a look at the insertBefore() method, which should solve the problem perfectly.
You're very close to the solution!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
|
|
||
| input.placeholder = formatedName; | ||
|
|
||
| input.parentElement.appendChild(label); |
There was a problem hiding this comment.
While appendChild correctly adds the label to the parent container, it places it at the very end, after the input field. The task's result.png shows the label appearing before the input. You might want to use a different method to insert the label at a specific position within the parent element.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work! You've successfully addressed the feedback from the previous review by using insertBefore() to correctly position the labels before the input fields. Your solution is clean, efficient, and now fully meets all the requirements of the task. I am approving this submission. Great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.