Skip to content

add task solution #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timurradkevic wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #1861

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66e65be
add task solution
Apr 6, 2026
5dde64a
add task solution
Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
1. Replace `<your_account>` with your Github username in the link
- [DEMO LINK](https://<your_account>.github.io/js_task_fix_form_DOM/)
- [DEMO LINK](https://timurradkevic.github.io/js_task_fix_form_DOM/)
2. Follow [this instructions](https://mate-academy.github.io/layout_task-guideline/)
- Run `npm run test` command to test your code;
- Run `npm run test:only -- -n` to run fast test ignoring linter;
Expand Down
14 changes: 13 additions & 1 deletion src/scripts/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
'use strict';

// write code here
const inputs = [...document.querySelectorAll('input')];
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task asks to get all input elements from the form tag. This selector gets all inputs on the page, regardless of whether they are in a form. To be more precise and adhere to the requirement, consider using document.querySelectorAll('form input').


for (const input of inputs) {
const label = document.createElement('label');

label.className = 'field-label';
label.for = input.id;
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because for is a reserved keyword in JavaScript, you cannot use it as a property name to set the for attribute. Instead, you should use the htmlFor property: label.htmlFor = input.id;.

label.textContent = input.name;
input.before(label);

input.placeholder =
input.name[0].toUpperCase() + input.name.slice(1).toLowerCase();
}
Loading