Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Good work on the core logic for creating labels and placeholders. However, there are two critical issues that need to be addressed.
First, the task instructions required that only the main.js file be changed, but src/styles/main.scss was also modified. Please revert the changes to the stylesheet.
Second, the script will crash if an input element doesn't have a name attribute (like a submit button). This is because inputName will be null, causing a TypeError when you try to call .charAt(0). You can fix this by adding a conditional check to make sure inputName exists before running the logic inside your loop.
Once these issues are resolved, your solution will be in great shape!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this iteration! I am happy to approve your submission. You've successfully addressed all the feedback from the previous review, making the script more robust by correctly handling inputs without a name attribute. Your solution now meets all the requirements perfectly. Great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
DEMO LINK