Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work on this task! Your script correctly adds and configures the labels and placeholders. I'm requesting one change to fully meet the project requirements. The task specifies getting all <input> elements from the <form> tag, but your current selector document.querySelectorAll('input') targets all inputs on the page. While this works for the current HTML, it's important to make the selector more specific, like 'form input', to ensure the code is robust and precisely follows the instructions. After you make this small adjustment, I'll be happy to approve your work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| 'use strict'; | ||
|
|
||
| // write code here | ||
| const inputs = document.querySelectorAll('input'); |
There was a problem hiding this comment.
This selector gets all <input> elements on the entire page. The requirement specifies getting inputs from the <form> tag. Using a more specific selector like 'form input' would be better practice and align more closely with the task description. This makes your code more robust in case other inputs exist outside the form.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this pull request! You've successfully addressed the feedback from the previous review by making the selector more specific. The script is now robust, clean, and fully meets all the requirements outlined in the task description. I am approving your solution. Great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.