Implementing getSalaryInfo - #1477
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Thank you for your hard work! 😊 There is a critical issue with the date range check in your SalaryInfo.java implementation: the current logic excludes workdays that fall exactly on the dateFrom or dateTo boundaries. According to the requirements, the report must include salaries for workdays that are inclusive of the start and end dates. Please update your condition to include records where the work date is equal to dateFrom, dateTo, or between them (for example, use !workDate.isBefore(startDate) && !workDate.isAfter(endDate)). Once you fix this, your solution should meet all the requirements! Keep going, you're almost there! 🚀
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| for (String userData : data) { | ||
| String[] workday = userData.split(" "); | ||
| LocalDate workDate = LocalDate.parse(workday[0], formatter); | ||
| if (startDate.isAfter(workDate) || endDate.isBefore(workDate)) { |
There was a problem hiding this comment.
This is an error related to the task requirements. The condition startDate.isAfter(workDate) || endDate.isBefore(workDate) excludes workdays that are exactly on the boundaries of dateFrom and dateTo. According to the checklist, the report must include salaries for workdays that are inclusive of the start and end dates. You should adjust the condition to include workdays that are on the boundary dates.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job! 🎉 Your implementation meets all the functional requirements and constraints, and you’ve addressed previous issues with the date range check. Everything is clear, well-structured, and ready to go—keep up the excellent work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
Implementing getSalaryInfo method in SalaryInfo class