-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Added solution for SalaryInfo class #1480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,51 @@ | ||
| package core.basesyntax; | ||
|
|
||
| import java.time.LocalDate; | ||
| import java.time.format.DateTimeFormatter; | ||
| import java.util.Arrays; | ||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
|
|
||
| public class SalaryInfo { | ||
| private final DateTimeFormatter dateTimeFormatter = DateTimeFormatter.ofPattern("dd.MM.yyyy"); | ||
|
|
||
| public String getSalaryInfo(String[] names, String[] data, String dateFrom, String dateTo) { | ||
| return null; | ||
| LocalDate from = LocalDate.parse(dateFrom, dateTimeFormatter); | ||
| LocalDate to = LocalDate.parse(dateTo, dateTimeFormatter); | ||
| Map<String, Integer> salaryMap = new HashMap<>(); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This violates the requirement: "Do not use HashMap or any other Map." You must use arrays for salary aggregation instead of a Map. |
||
|
|
||
| for (String record : data) { | ||
| String[] parts = record.split(" "); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This violates the checklist item: "All hardcoded values (magic numbers) must be moved to constants with descriptive names." The indices used for splitting the data line (e.g., parts[0], parts[1], parts[2], parts[3]) should be declared as constants. |
||
|
|
||
| LocalDate date = LocalDate.parse(parts[0], dateTimeFormatter); | ||
|
|
||
| if (date.isAfter(to) || date.isBefore(from)) { | ||
| continue; | ||
| } | ||
|
|
||
| String name = parts[1]; | ||
|
|
||
| if (!Arrays.asList(names).contains(name)) { | ||
| continue; | ||
| } | ||
|
|
||
| int hours = Integer.parseInt(parts[2]); | ||
| int rate = Integer.parseInt(parts[3]); | ||
| int salary = hours * rate; | ||
|
|
||
| salaryMap.put(name, salaryMap.getOrDefault(name, 0) + salary); | ||
|
|
||
| } | ||
|
|
||
| StringBuilder builder = new StringBuilder(); | ||
| builder.append("Report for period ").append(dateFrom).append(" - ").append(dateTo) | ||
| .append(System.lineSeparator()); | ||
|
|
||
| for (String name : names) { | ||
| int totalSalary = salaryMap.getOrDefault(name, 0); | ||
| builder.append(name).append(" - ").append(totalSalary).append(System.lineSeparator()); | ||
| } | ||
|
|
||
| return builder.toString().trim(); | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This violates the requirement: "If a date formatter is created, it must be a constant field." The formatter should be a static final field, not an instance field.