Skip to content
Open
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 50 additions & 2 deletions src/main/java/core/basesyntax/SalaryInfo.java
Original file line number Diff line number Diff line change
@@ -1,7 +1,55 @@
package core.basesyntax;

import java.time.LocalDate;
import java.time.format.DateTimeFormatter;
import java.util.Arrays;

public class SalaryInfo {
public String getSalaryInfo(String[] names, String[] data, String dateFrom, String dateTo) {
return null;
private static final DateTimeFormatter dateTimeFormatter =

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates the checklist item: "If a date formatter is used, it must be a constant with an informative name." The constant should be named in uppercase with underscores (e.g., DATE_TIME_FORMATTER) as per Java conventions and the checklist.

DateTimeFormatter.ofPattern("dd.MM.yyyy");

public String getSalaryInfo(String[] names, String[] data,
String dateFrom, String dateTo) {
LocalDate from = LocalDate.parse(dateFrom, dateTimeFormatter);
LocalDate to = LocalDate.parse(dateTo, dateTimeFormatter);

int[] salaries = new int[names.length];

for (String record : data) {
String[] parts = record.split(" ");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates the checklist item: "All hardcoded values (magic numbers) must be moved to constants with descriptive names." The indices used for splitting the data line (e.g., parts[0], parts[1], parts[2], parts[3]) should be declared as constants.


LocalDate date = LocalDate.parse(parts[0], dateTimeFormatter);

if (date.isAfter(to) || date.isBefore(from)) {
continue;
}

String name = parts[1];

if (!Arrays.asList(names).contains(name)) {
continue;
}

int hours = Integer.parseInt(parts[2]);
int rate = Integer.parseInt(parts[3]);
int salary = hours * rate;

int index = Arrays.asList(names).indexOf(name);
salaries[index] += salary;
}

StringBuilder builder = new StringBuilder();
builder.append("Report for period ").append(dateFrom).append(" - ").append(dateTo)
.append(System.lineSeparator());

for (int i = 0; i < names.length; i++) {
int totalSalary = salaries[i];

builder.append(names[i]).append(" - ")
.append(totalSalary)
.append(System.lineSeparator());
}

return builder.toString().trim();
}
}