Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 40 additions & 1 deletion src/main/java/core/basesyntax/SalaryInfo.java
Original file line number Diff line number Diff line change
@@ -1,7 +1,46 @@
package core.basesyntax;

import java.time.LocalDate;
import java.time.format.DateTimeFormatter;
import java.util.Arrays;

public class SalaryInfo {
private static final int HOURS_INDEX = 2;
private static final int RATE_INDEX = 3;
private static final int DATE_INDEX = 0;
private static final int NAME_INDEX = 1;
private static final DateTimeFormatter formatter = DateTimeFormatter.ofPattern("dd.MM.yyyy");

public String getSalaryInfo(String[] names, String[] data, String dateFrom, String dateTo) {
return null;
LocalDate to = LocalDate.parse(dateTo, formatter);
LocalDate from = LocalDate.parse(dateFrom, formatter);
int[] salaries = new int[names.length];
StringBuilder stringBuilder = new StringBuilder()
.append("Report for period ")
.append(dateFrom).append(" - ")
.append(dateTo)
.append(System.lineSeparator());
for (String record : data) {
String[] parts = record.split(" ");
String date = parts[DATE_INDEX];
String name = parts[NAME_INDEX];
int hours = Integer.parseInt(parts[HOURS_INDEX]);
int rate = Integer.parseInt(parts[RATE_INDEX]);
LocalDate recordDate = LocalDate.parse(date, formatter);
if (!recordDate.isBefore(from) && !recordDate.isAfter(to)) {
int index = Arrays.asList(names).indexOf(name);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a potential bug here: if name from data is not present in the names array, Arrays.asList(names).indexOf(name) returns -1, causing salaries[-1] access and an ArrayIndexOutOfBoundsException. The task description doesn’t guarantee that all names in data are in names, so you should guard against index == -1 before using it.

if (index >= 0) {
salaries[index] += hours * rate;
}
}
}
for (int i = 0; i < names.length; i++) {
stringBuilder.append(names[i])
.append(" - ").append(salaries[i]);
if (i < names.length - 1) {
stringBuilder.append(System.lineSeparator());
}
}
return stringBuilder.toString();
}
}
Loading