Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 57 additions & 1 deletion src/main/java/core/basesyntax/SalaryInfo.java
Original file line number Diff line number Diff line change
@@ -1,7 +1,63 @@
package core.basesyntax;

import java.time.LocalDate;
import java.time.format.DateTimeFormatter;

public class SalaryInfo {
private static final DateTimeFormatter DATE_FORMATTER =
DateTimeFormatter.ofPattern("dd.MM.yyyy");

private static final String REPORT_HEADER = "Report for period ";
private static final String DATE_SEPARATOR = " - ";
private static final String NAME_SALARY_SEPARATOR = " - ";
private static final String DATA_SEPARATOR = " ";

private static final int DATE_INDEX = 0;
private static final int NAME_INDEX = 1;
private static final int HOURS_INDEX = 2;
private static final int RATE_INDEX = 3;

public String getSalaryInfo(String[] names, String[] data, String dateFrom, String dateTo) {
return null;
LocalDate startDate = LocalDate.parse(dateFrom, DATE_FORMATTER);
LocalDate endDate = LocalDate.parse(dateTo, DATE_FORMATTER);

StringBuilder report = new StringBuilder();
report.append(REPORT_HEADER)
.append(dateFrom)
.append(DATE_SEPARATOR)
.append(dateTo);

for (String name : names) {
int salary = calculateSalary(name, data, startDate, endDate);

report.append(System.lineSeparator())
.append(name)
.append(NAME_SALARY_SEPARATOR)
.append(salary);
}

return report.toString();
}

Comment on lines +40 to +41

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #1: 'Don't begin class or method implementation with an empty line.' Remove the empty line before the calculateSalary method declaration.

private int calculateSalary(String name, String[] data,
LocalDate startDate, LocalDate endDate) {
int salary = 0;

for (String record : data) {
String[] recordParts = record.split(DATA_SEPARATOR);

LocalDate workDate = LocalDate.parse(recordParts[DATE_INDEX], DATE_FORMATTER);
String employeeName = recordParts[NAME_INDEX];
int hours = Integer.parseInt(recordParts[HOURS_INDEX]);
int rate = Integer.parseInt(recordParts[RATE_INDEX]);

if (employeeName.equals(name)
&& !workDate.isBefore(startDate)
&& !workDate.isAfter(endDate)) {
salary += hours * rate;
}
}

return salary;
}
}
Loading