-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Salary info done #1591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mcDirek
wants to merge
1
commit into
mate-academy:master
Choose a base branch
from
mcDirek:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Salary info done #1591
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,63 @@ | ||
| package core.basesyntax; | ||
|
|
||
| import java.time.LocalDate; | ||
| import java.time.format.DateTimeFormatter; | ||
|
|
||
| public class SalaryInfo { | ||
| private static final DateTimeFormatter DATE_FORMATTER = | ||
| DateTimeFormatter.ofPattern("dd.MM.yyyy"); | ||
|
|
||
| private static final String REPORT_HEADER = "Report for period "; | ||
| private static final String DATE_SEPARATOR = " - "; | ||
| private static final String NAME_SALARY_SEPARATOR = " - "; | ||
| private static final String DATA_SEPARATOR = " "; | ||
|
|
||
| private static final int DATE_INDEX = 0; | ||
| private static final int NAME_INDEX = 1; | ||
| private static final int HOURS_INDEX = 2; | ||
| private static final int RATE_INDEX = 3; | ||
|
|
||
| public String getSalaryInfo(String[] names, String[] data, String dateFrom, String dateTo) { | ||
| return null; | ||
| LocalDate startDate = LocalDate.parse(dateFrom, DATE_FORMATTER); | ||
| LocalDate endDate = LocalDate.parse(dateTo, DATE_FORMATTER); | ||
|
|
||
| StringBuilder report = new StringBuilder(); | ||
| report.append(REPORT_HEADER) | ||
| .append(dateFrom) | ||
| .append(DATE_SEPARATOR) | ||
| .append(dateTo); | ||
|
|
||
| for (String name : names) { | ||
| int salary = calculateSalary(name, data, startDate, endDate); | ||
|
|
||
| report.append(System.lineSeparator()) | ||
| .append(name) | ||
| .append(NAME_SALARY_SEPARATOR) | ||
| .append(salary); | ||
| } | ||
|
|
||
| return report.toString(); | ||
| } | ||
|
|
||
| private int calculateSalary(String name, String[] data, | ||
| LocalDate startDate, LocalDate endDate) { | ||
| int salary = 0; | ||
|
|
||
| for (String record : data) { | ||
| String[] recordParts = record.split(DATA_SEPARATOR); | ||
|
|
||
| LocalDate workDate = LocalDate.parse(recordParts[DATE_INDEX], DATE_FORMATTER); | ||
| String employeeName = recordParts[NAME_INDEX]; | ||
| int hours = Integer.parseInt(recordParts[HOURS_INDEX]); | ||
| int rate = Integer.parseInt(recordParts[RATE_INDEX]); | ||
|
|
||
| if (employeeName.equals(name) | ||
| && !workDate.isBefore(startDate) | ||
| && !workDate.isAfter(endDate)) { | ||
| salary += hours * rate; | ||
| } | ||
| } | ||
|
|
||
| return salary; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This violates checklist item #1: 'Don't begin class or method implementation with an empty line.' Remove the empty line before the calculateSalary method declaration.