-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Implemented method getSalaryInfo(String[] names, String[] data, Strin… #1594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LizaBrnk
wants to merge
4
commits into
mate-academy:master
Choose a base branch
from
LizaBrnk:salary-task
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
52aef78
Implemented method getSalaryInfo(String[] names, String[] data, Strin…
LizaBrnk 09c7d64
solved problems with local variable and magic number
LizaBrnk f6ad416
solved problems with local variable and magic number
LizaBrnk 4c8e19b
solved problems with local variable and magic number
LizaBrnk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,45 @@ | ||
| package core.basesyntax; | ||
|
|
||
| import java.time.LocalDate; | ||
| import java.time.format.DateTimeFormatter; | ||
|
|
||
| public class SalaryInfo { | ||
| public String getSalaryInfo(String[] names, String[] data, String dateFrom, String dateTo) { | ||
| return null; | ||
| private static final String DATE_FORMAT_PATTERN = "dd.MM.yyyy"; | ||
| private static final DateTimeFormatter formatter | ||
| = DateTimeFormatter.ofPattern(DATE_FORMAT_PATTERN); | ||
|
|
||
| public String getSalaryInfo(String[] names, | ||
| String[] data, | ||
| String dateFrom, | ||
| String dateTo) { | ||
| StringBuilder result = new StringBuilder(); | ||
| LocalDate from = LocalDate.parse(dateFrom, formatter); | ||
| LocalDate to = LocalDate.parse(dateTo, formatter); | ||
|
|
||
| result.append("Report for period ") | ||
| .append(dateFrom) | ||
| .append(" - ") | ||
| .append(dateTo); | ||
|
|
||
| for (String name : names) { | ||
| int salary = 0; | ||
|
|
||
| for (String line : data) { | ||
| String[] info = line.split(" "); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The magic number " " (space character used for splitting data strings) should be extracted as a private static final constant with an informative name, as required by checklist item #8. |
||
| LocalDate date = LocalDate.parse(info[0], formatter); | ||
|
|
||
| if (info[1].equals(name) && !date.isBefore(from) && !date.isAfter(to)) { | ||
| salary += Integer.parseInt(info[2]) * Integer.parseInt(info[3]); | ||
| } | ||
|
|
||
| } | ||
|
|
||
| result.append(System.lineSeparator()) | ||
| .append(name) | ||
| .append(" - ") | ||
| .append(salary); | ||
| } | ||
|
|
||
| return result.toString(); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 8 exceeds 100 characters (104 characters). Break the formatter assignment across multiple lines with proper indentation, similar to how method parameters are formatted on lines 11-14.