Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work on the overall layout and functionality! You've correctly used flexbox and implemented the active link state with a pseudo-element. However, this submission requires a few changes to meet the project's core requirements. The main issue is that your CSS uses tag selectors like header and nav ul for styling, which is explicitly disallowed by the task rules. Please add classes to these HTML elements and update your CSS to target those classes. Also, for better accessibility, the alt text for the logo should be more descriptive, such as "Moyo company logo". After you've addressed these points, your solution will be in great shape!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| > | ||
| <img | ||
| src="./images/logo.png" | ||
| alt="logo" |
There was a problem hiding this comment.
The alt attribute text is a bit too generic. A more descriptive text like "Moyo company logo" would be better for accessibility and SEO, as it more clearly describes what the image is.
| display: flex; | ||
| align-items: center; | ||
| font-size: 12px; | ||
| line-height: 15px; |
There was a problem hiding this comment.
The alt attribute value logo is a bit generic. The code style rules recommend describing the image content more specifically. A better alternative would be Moyo company logo to provide more context for users with screen readers.
…tors changed to classes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work addressing the previous feedback! The project is very close to completion, but there is one functional requirement that needs to be fixed. The text within the navigation links is currently only centered vertically. To match the design requirements, it must also be centered horizontally. You can achieve this by adding justify-content: center; to your .nav_link rule in src/style.css.
Additionally, as a good practice, consider adding a class to the <nav> element in src/index.html for better style consistency. Once the text alignment is corrected, your solution will be ready for approval. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| alt="Moyo company logo" | ||
| /> | ||
| </a> | ||
| <nav> |
There was a problem hiding this comment.
According to the good practices shown in the checklist file, it's recommended to add a class to semantic elements like <nav> (e.g., <nav class="nav">). This helps in maintaining a consistent styling approach and avoids using tag selectors.
|
|
||
| .nav_link { | ||
| display: flex; | ||
| align-items: center; |
There was a problem hiding this comment.
The requirement is for the navigation link text to be centered. You've correctly centered it vertically using align-items: center. To fully meet the requirement, you also need to center it horizontally. You can achieve this by adding one more flexbox property here.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this submission! You've done a great job addressing the previous feedback and successfully centering the navigation link text. Your HTML is semantic, your CSS is clean, and the final result perfectly matches the design requirements. The implementation is clean and correct, meeting all project standards. I'm happy to approve your solution. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
DEMO LINK
TEST REPORT LINK
Header height is set in 1 place (for the links)
Content is vertically centered (for any header height)
CSS is used to show all letters in Uppercase (don't type them in HTML)
Logo is an image wrapped with a link
CSS Variable is used for a blue color
Pseudo-element is used for a blue line below the active link
Code follows all the Code Style Rules ❗️
The Google Fonts Configuration follows requirements.