Develop #7742
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| name: Test | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [ master ] | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [20.x] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: npm install | ||
| - run: npm test | ||
| - name: Upload HTML report(backstop data) | ||
| if: ${{ always() }} | ||
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: report | ||
| path: backstop_data |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,12 +11,107 @@ | |
| content="ie=edge" | ||
| /> | ||
| <title>Moyo header</title> | ||
| <link | ||
| rel="preconnect" | ||
| href="https://fonts.googleapis.com" | ||
| /> | ||
| <link | ||
| rel="preconnect" | ||
| href="https://gstatic.com" | ||
| crossorigin="anonymous" | ||
|
Comment on lines
+18
to
+21
There was a problem hiding this comment. Preconnect target is incorrect: you preconnect to "https://gstatic.com" but the correct domain for Google Fonts static files is "https://fonts.gstatic.com". Update the preconnect href to fonts.gstatic.com (keep crossorigin as needed). This is part of the Google Fonts configuration checklist. |
||
| /> | ||
|
|
||
| <link | ||
| href="https://fonts.googleapis.com/css2?family=Roboto+Mono:ital,wght@0,100..700;1,100..700&family=Roboto:wght@500&display=swap" | ||
| rel="stylesheet" | ||
|
Comment on lines
+23
to
+25
There was a problem hiding this comment. This violates checklist item #8: "The Google Fonts Configuration follows requirements." The font includes extra families (e.g. Roboto Mono and multiple styles). The task requires embedding ONLY Roboto (roman style), medium weight (500), normal width. Update the Google Fonts URL to request only Roboto with weight 500. |
||
| /> | ||
| <link | ||
| rel="stylesheet" | ||
| href="./style.css" | ||
| /> | ||
| </head> | ||
|
Comment on lines
+26
to
31
There was a problem hiding this comment. This also violates checklist item #7. The |
||
| <body> | ||
| <header class="header"> | ||
| <a | ||
| href="./" | ||
| class="logo" | ||
| > | ||
| <img | ||
| src="./images/logo.png" | ||
| alt="Logo" | ||
|
There was a problem hiding this comment. The checklist states: " |
||
| class="logo-img" | ||
| /> | ||
| </a> | ||
|
|
||
| <nav class="nav"> | ||
| <ul class="nav-list"> | ||
| <li class="nav-item"> | ||
| <a | ||
| href="#" | ||
| class="nav-link is-active" | ||
| > | ||
| apple | ||
| </a> | ||
| </li> | ||
| <li class="nav-item"> | ||
| <a | ||
| href="#" | ||
| class="nav-link" | ||
|
Comment on lines
+55
to
+59
There was a problem hiding this comment. You have a |
||
| > | ||
| samsung | ||
| </a> | ||
| </li> | ||
| <li class="nav-item"> | ||
| <a | ||
| href="#" | ||
| class="nav-link" | ||
| > | ||
| smartphones | ||
| </a> | ||
| </li> | ||
| <li class="nav-item"> | ||
| <a | ||
| href="#" | ||
| class="nav-link" | ||
| data-qa="hover" | ||
| > | ||
| laptops & computers | ||
| </a> | ||
| </li> | ||
| <li class="nav-item"> | ||
| <a | ||
| href="#" | ||
| class="nav-link" | ||
| > | ||
| gadgets | ||
| </a> | ||
| </li> | ||
| <li class="nav-item"> | ||
| <a | ||
| href="#" | ||
| class="nav-link" | ||
| > | ||
| tablets | ||
| </a> | ||
| </li> | ||
| <li class="nav-item"> | ||
| <a | ||
| href="#" | ||
| class="nav-link" | ||
| > | ||
| photo | ||
| </a> | ||
| </li> | ||
| <li class="nav-item"> | ||
| <a | ||
| href="#" | ||
| class="nav-link" | ||
| > | ||
| video | ||
| </a> | ||
| </li> | ||
| </ul> | ||
| </nav> | ||
| </header> | ||
| </body> | ||
| </html> | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This violates checklist item #7: "Code follows all the Code Style Rules ❗️". You are styling many tag names in a group selector (header, nav, ul, li, a, img) to reset margins/paddings (lines below). The Code Style rules require you to avoid using tag selectors (except html and body). For resets, set margins on html, body only. Replace this block with a minimal reset targeting html, body and use classes for other element-specific styles.