solution: complete moyo header layout #7747
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| name: Test | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [ master ] | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [20.x] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: npm install | ||
| - run: npm test | ||
| - name: Upload HTML report(backstop data) | ||
| if: ${{ always() }} | ||
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: report | ||
| path: backstop_data |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,66 @@ | ||
| :root { | ||
| --main-blue: #00acdc; | ||
| } | ||
|
|
||
| body { | ||
| margin: 0; | ||
| font-family: Roboto, sans-serif; | ||
|
There was a problem hiding this comment. The PR description must include your demo/test links and the copied Checklist block. Please add and complete these exactly as required. Quoting the checklist items that are not satisfied in the PR description:
Action: update your Pull Request description — include the DEMO and TEST REPORT links with your GitHub username in place of |
||
| font-size: 14px; | ||
| } | ||
|
|
||
| .header { | ||
| padding: 0 50px; | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: space-between; | ||
| } | ||
|
|
||
| .logo { | ||
| display: flex; | ||
| margin-right: 30px; | ||
| } | ||
|
|
||
| .nav__list { | ||
| list-style: none; | ||
| padding: 0; | ||
| margin: 0; | ||
| display: flex; | ||
| } | ||
|
|
||
| .nav__item:not(:last-child) { | ||
| margin-right: 20px; | ||
| } | ||
|
|
||
| .nav__link { | ||
| color: #000; | ||
| text-transform: uppercase; | ||
| text-decoration: none; | ||
| font-weight: 500; | ||
| height: 60px; | ||
| display: flex; | ||
| align-items: center; | ||
| position: relative; | ||
| transition: color 0.3s; | ||
| font-size: 12px; | ||
| line-height: 14px; | ||
| } | ||
|
xundseth marked this conversation as resolved.
|
||
|
|
||
| .nav__link:hover { | ||
| color: var(--main-blue); | ||
| } | ||
|
|
||
| .nav__link.is-active { | ||
| color: var(--main-blue); | ||
| } | ||
|
|
||
| .nav__link.is-active::after { | ||
| content: ''; | ||
| position: absolute; | ||
| right: 0; | ||
| bottom: 0; | ||
| left: 0; | ||
| width: 100%; | ||
| height: 4px; | ||
| background-color: var(--main-blue); | ||
| border-radius: 8px; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This violates checklist item: "Lines of code have 80 chars max". The Google Fonts block is too long on the single attribute line. Also follow the checklist guidance: "If the HTML element has long attribute values or number of attributes is more than 2 - start each one, including the first, on the new line with 2-space indentation related to tag. Tag’s closing bracket should be on the same level as opening one." Wrap/split the long tag (or its attributes) so no physical line exceeds 80 characters (for example put each attribute on its own indented line and ensure the long URL line stays under 80 chars).