Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/test.yml-template
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
1 change: 1 addition & 0 deletions node_accounting-app-v2
Submodule node_accounting-app-v2 added at e7bf2a
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"license": "GPL-3.0",
"devDependencies": {
"@mate-academy/eslint-config": "latest",
"@mate-academy/scripts": "^1.8.6",
"@mate-academy/scripts": "^2.1.3",
"eslint": "^8.57.0",
"eslint-plugin-jest": "^28.6.0",
"eslint-plugin-node": "^11.1.0",
Expand Down
66 changes: 63 additions & 3 deletions src/createServer.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,63 @@
// Write code here
// Also, you can create additional files in the src folder
// and import (require) them here
const http = require('http');
const { convertToCase } = require('./convertToCase');

const createServer = () => {
return http.createServer((req, res) => {
const [rawText, queryString] = req.url.split('?');
const text = rawText.slice(1);
const params = new URLSearchParams(queryString);
const toCase = params.get('toCase');
const supportedCases = ['SNAKE', 'KEBAB', 'CAMEL', 'PASCAL', 'UPPER'];
const errors = [];

if (text === '') {
errors.push({
message:
'Text to convert is required. Correct request is: ' +
'"/<TEXT_TO_CONVERT>?toCase=<CASE_NAME>".',
});
}

if (toCase === null) {
errors.push({
message:
'"toCase" query param is required. Correct request is: ' +
'"/<TEXT_TO_CONVERT>?toCase=<CASE_NAME>".',
});
}

if (toCase !== null && !supportedCases.includes(toCase.toUpperCase())) {
errors.push({
message:
'This case is not supported. Available cases: SNAKE, KEBAB, ' +
'CAMEL, PASCAL, UPPER.',
});
}

if (errors.length > 0) {
res.setHeader('Content-Type', 'application/json');
res.statusCode = 400;
res.statusMessage = 'Bad request';
res.end(JSON.stringify({ errors }));

return;
}

const result = convertToCase(text, toCase);
Comment on lines +28 to +46

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validation converts toCase to uppercase for checking (toCase.toUpperCase()), but line 46 passes the original toCase value to convertToCase. If the business logic expects uppercase values (as the supportedCases array suggests), this inconsistency could cause issues. Consider passing toCase.toUpperCase() to convertToCase for consistency.


res.setHeader('Content-Type', 'application/json');
res.statusCode = 200;
res.statusMessage = 'OK';

res.end(
JSON.stringify({
originalCase: result.originalCase,
targetCase: toCase,
originalText: text,
convertedText: result.convertedText,
}),
);
});
};

module.exports = { createServer };
Loading