Skip to content

Solution #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gospodenkolubomir-oss wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #2183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,19 @@
from typing import Callable
import functools


def cache(func: Callable) -> Callable:
# Write your code here
pass
def cache(func: Callable) -> Callable[..., None]:
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type hint Callable[..., None] is incorrect. The decorator returns a wrapper function which in turn returns the result of the original function, not None. Consider using typing.Any to indicate that the wrapped function can return a value of any type.

Copy link
Copy Markdown
Contributor

@vsmutok vsmutok Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type hint Callable[..., None] is incorrect. The decorator returns a wrapper function which in turn returns the result of the original function, not None. Consider using typing.Any to indicate that the wrapped function can return a value of any type.

local_cache = {}

@functools.wraps(func)
def wrapper(*args, **kwargs) -> None:
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wrapper's return type is hinted as None, but the function returns a value on lines 13 and 18. This should be corrected to reflect the actual return type, for example by importing Any from typing and using it here.

Copy link
Copy Markdown
Contributor

@vsmutok vsmutok Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wrapper's return type is hinted as None, but the function returns a value on lines 13 and 18. This should be corrected to reflect the actual return type, for example by importing Any from typing and using it here.

key = (args, tuple(sorted(kwargs.items())))
if key in local_cache:
print("Getting from cache")
return local_cache[key]
else:
print("Calculating new result")
result = func(*args, **kwargs)
local_cache[key] = result
return result
return wrapper
Comment on lines +11 to +19
Copy link
Copy Markdown
Contributor

@vsmutok vsmutok Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if key in local_cache:
print("Getting from cache")
return local_cache[key]
else:
print("Calculating new result")
result = func(*args, **kwargs)
local_cache[key] = result
return result
return wrapper
if key in local_cache:
print("Getting from cache")
else:
print("Calculating new result")
local_cache[key] = func(*args, **kwargs)
return local_cache[key]
return wrapper

Loading