Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on the cache decorator! Your implementation is clean, efficient, and correctly meets all the functional requirements. The logic for caching results and handling multiple decorated functions is spot-on.
I am approving your submission. Please note that the automated check failed due to a minor style issue reported by the linter (E306). This is a non-blocking error that simply requires adding a blank line before the nested wrapper function definition in app/main.py for better readability.
Great job on this task!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Changes are needed because the required cache decorator implementation is missing — no Python files (including app/main.py) were submitted for review, only .gitignore is present. Without the actual code, I cannot verify any core functionality: whether the decorator caches results, prints "Getting from cache" or "Calculating new result", handles immutable arguments correctly, or supports multiple decorated functions simultaneously. All checklist items — including [CHECKLIST ITEM #1] (store and reuse results) and [CHECKLIST ITEM #2] (no duplicated code) — remain unverifiable due to the missing implementation. Please upload your app/main.py containing the cache decorator so I can complete a full, accurate review.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
I am approving your solution as an educational override to help you progress while learning — this is a great opportunity to deepen your understanding of hashable keys and decorator design. You've done well implementing cache isolation across functions, correctly printing cache and calculation messages, and handling *args cleanly. However, there's an important learning point: tuple(kwargs.items()) creates unhashable dict_items objects, which will raise a TypeError when keyword arguments are passed — fix this by using tuple(sorted(kwargs.items())) instead to ensure the key is always hashable [CHECKLIST ITEM #3]. Also, make sure your key construction consistently combines args and kwargs in a way that avoids ambiguity or collisions. Keep up the excellent work — these are common, surmountable challenges on the path to mastering decorators!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| def cache(func: Callable) -> Callable: | ||
| # Write your code here | ||
| pass | ||
| deco_cache = {} | ||
|
|
||
| @wraps(func) | ||
| def wrapper(*args: Any, **kwargs: Any) -> Any: | ||
| key = tuple(args) + tuple(kwargs.items()) |
2 participants
create cache decorator