Skip to content

Solution #2192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ulamelnyk wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solution #2192

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7233865
Solution
ulamelnyk Apr 12, 2026
80466f3
more solutions
ulamelnyk Apr 12, 2026
ca53371
and more solutions
ulamelnyk Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,17 @@
from typing import Callable
from typing import Callable, Any


def cache(func: Callable) -> Callable:
# Write your code here
pass
cash = {}
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable name cash looks like a typo and doesn't follow the checklist requirement: "Use descriptive and correct variable names." Rename it to a clearer name such as cache or storage to improve readability and correctness.


def wrapper(*args, **kwargs) -> Any:
if args in cash:
print("Getting from cache")
return cash[args]
else:
print("Calculating new result")
result = func(*args, **kwargs)
Comment on lines +9 to +17
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This uses only args as the cache key and completely ignores kwargs, so calls that differ only by keyword arguments will be cached incorrectly. The task requires a decorator that "stores results of completed runs with different arguments, number of arguments can be also different." Consider creating a composite, hashable key that includes both positional and keyword arguments (for example: key = (args, frozenset(kwargs.items()))).

cash[args] = result
return result

return wrapper
Loading