feat: run on desktop - #678
Conversation
|
Checked the failures:
|
faf7008 to
d5e03c9
Compare
|
Hi @mateusz-bak, could you please help reviewing this and couple more PRs? Or maybe there is someone else with write permissions who could help? |
a63eec2 to
6645da5
Compare
6645da5 to
c68f954
Compare
There was a problem hiding this comment.
Change already made, please rebase
| file_picker: ^8.3.1 | ||
| smooth_page_indicator: ^1.1.0 | ||
| intl: ^0.19.0 | ||
| intl: ^0.20.0 |
There was a problem hiding this comment.
Change already made, please rebase
There was a problem hiding this comment.
Change already made, please rebase
There was a problem hiding this comment.
Hi! Thanks for the work, looks like a good improvement.
However I don't see linux or windows directories that I suppose were created after running below command:
flutter create --platforms=linux,windows .
Also please rebase to fix conflicts on already done changes.
c68f954 to
a233e5f
Compare
|
Hi! I would like give some help to merge this PR. Could you give me an update on the current status of the PR and any blockers you’re facing? Thanks in advance :) |
a233e5f to
006403c
Compare
|
Hi, I've rebased the changes on top of the current HEAD and added the linux platform directory. Regarding windows platform directory and build, I didn't add it because I haven't tested it there and won't be able to. One more thing that is missing yet is an automatic build configuration for linux. We won't be able to distribute the linux version without that. |
|
Hi! Has it evolved since last month?? (I can't wait to get OpenReads on my desktop bc i don't have a smartphone anymore) |
8f86985 to
5f40d63
Compare
|
Hi @mateusz-bak, could you please review? The linux build had been added to the test_build.yaml and the I've also made the github workflow store debug build artifacts to allow reviewers run a new version without having to build it locally. |
|
BTW folks. While we're waiting for review you can try it out using the build artifacts: https://github.com/mateusz-bak/openreads/actions/runs/19399497883 To use it:
I did fix everything platform-specific I could fine, but I might've missed something. So let me know if it's crashing or silently ignoring you. CC: @armand-leguillou, @amoinier, @ironhak, @GLLM |
|
Great work @RomanKovtyukh I'm starting the review, I'll try to finish it by tomorrow. |
|
Now that I think more about it, a great way to solve this would be to grey out the elements that aren't implemented yet, and show the reason in a tooltip when hovering over them.
But I understand if that's too much work for now.
|
|
Agree! Greyed out buttons would be best! We can implement them after we merge this PR. |
|
Hi folks. Wanted to clarify what we want to do. I'd keep everything as is to keep it a bit less spread in code. I've created a feature request for the currently hidden bar code scanning feature: #878 and ready to add other features. |
|
Thanks, your suggestions sound great to me! 💪 Happy to hear that it's easy to do, and even if tooltips on hover aren't easy, messages on click are a reasonable fallback 😊
|
d0b52a1 to
c4265ca
Compare
|
Ok, made inactive buttons transparent and with same info bar showing a warning message (translated). It's quite ugly in code, but hopefully will be fixed quickly after merging this PR because most of the things are about working with CSVs which I expect to be fixed all together. |
| "show_title_over_cover": "Show title over cover" | ||
| } No newline at end of file | ||
| "show_title_over_cover": "Show title over cover", | ||
| "unsupported_platform_blur_hash_error": "Unsupported platform for generating BlurHash", |
There was a problem hiding this comment.
Please combine all unsuported... strings to one:
This action is not supported on current platform
This will make life easier for the translator especially that we are going to support the features soon.
| Constants.blurHashX, | ||
| Constants.blurHashY, | ||
| ); | ||
| } else { |
There was a problem hiding this comment.
I don't think we need to have the else statement. When we have new platforms we will review the platform specific implementations so no point in keeping the exception placeholders..
mateusz-bak
left a comment
There was a problem hiding this comment.
Great work, I added small comments. Please fix and also rebase
It includes sql configuration for windows, but it's testted only on Linux. Got an example from here: https://github.com/alextekartik/flutter_app_example/blob/96cba15d72e82ad739323f489b261014e3854484/demo_sqflite/lib/main.dart#L15-L21
Make unzipping the archive synchronous to avoid reading files from backup before they got extracted. In the backup v5 the `info.txt` file is getting extracted first to avoid extracting the whole archive before it's confirmed to be a valid backup.
c4265ca to
53daf06
Compare
|
Addressed the last comments, @mateusz-bak. |
|
I'm checking the CSV export and not sure if I understand right what this is doing on iOS: and how should I work it around on Linux (SharePlus doesn't implement fire share on Linux). Seem like it's opening sharing menu after saving CSV file, but I can't check it. Do we need to do that on Android too? Or it's done on iOS because it's not straightforward there where the file was saved and users in most cases would have to choose another path? Other than that it's working ok on Linux, so I event can add to this PR or open another one right after this. |
|
A commit in fork with basic CSV export. One issue is that it's not asking where to store the result backup. |

It includes sqlite configuration for windows, but only tested on Linux. Got an example from here so decided not to remove the
Platform.isWindowsfrom there.Before this change openreads was showing the following errors at the startup if you try running it on desktop:
#584