Skip to content

fix(windows): quote diff-pane argv so git receives the delta pager intact #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mathix420 merged 1 commit into from
Jun 12, 2026
Merged

fix(windows): quote diff-pane argv so git receives the delta pager intact #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions alacritree/src/session.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,9 +306,14 @@ impl Session {
working_directory: working_directory.clone(),
drain_on_exit: false,
env: config.env.clone(),
// `Options` has a Windows-only `escape_args` field; leaning on
// `Default` keeps the literal compilable on every target.
..Default::default()
// Windows has no argv: alacritty_terminal joins these args into a
// single CreateProcess command line, quoting them only when this
// is set. Diff panes pass argv built in code, where an arg with a
// space (delta's pager spec, file paths) must survive as one
// argument; shell args from alacritty.toml stay raw to match
// upstream alacritty.
#[cfg(windows)]
escape_args: matches!(kind, SessionKind::Diff { .. }),
};

// alacritty routes OSC 7 / signals by this id, so each session needs its own.
Expand Down