MediaProxy: refuse to serve media whose source event has been redacted - #527
Open
nbuechner wants to merge 1 commit into
Open
MediaProxy: refuse to serve media whose source event has been redacted#527nbuechner wants to merge 1 commit into
nbuechner wants to merge 1 commit into
Conversation
The proxy previously fetched media purely by its MXC URI, so a redacted event's media (e.g. NSFW content removed on Matrix) remained accessible to anyone who still had the proxy URL. generateMediaUrl() now optionally binds the source room/event into the signed media token, and the download handler checks unsigned.redacted_because before proxying. Fixes matrix-org/matrix-appservice-irc#1849
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generateMediaUrl()now optionally binds the source room/event into the signed media token.unsigned.redacted_becauseon the source event before proxying, refusing (404) if the event has been redacted or can't be verified.Test plan
Fixes matrix-org/matrix-appservice-irc#1849