Skip to content

fix(session verification): drop incoming requests we can't complete - #6971

Open
stefanceriu wants to merge 1 commit into
mainfrom
verificationRequestMissingSecrets
Open

fix(session verification): drop incoming requests we can't complete#6971
stefanceriu wants to merge 1 commit into
mainfrom
verificationRequestMissingSecrets

Conversation

@stefanceriu

Copy link
Copy Markdown
Member

A verified session that is missing the private self-signing key can neither sign the other device nor be signed by it, so the request is no longer surfaced to the delegate.

Based off the discussions in element-hq/element-x-ios#6099

A verified session that is missing the private self-signing key can neither
sign the other device nor be signed by it, so the request is no longer
surfaced to the delegate.
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.22%. Comparing base (7def4e6) to head (5a6ba5d).
⚠️ Report is 9 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6971      +/-   ##
==========================================
- Coverage   90.23%   90.22%   -0.01%     
==========================================
  Files         408      408              
  Lines      117281   117281              
  Branches   117281   117281              
==========================================
- Hits       105823   105818       -5     
- Misses       7511     7516       +5     
  Partials     3947     3947              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@stefanceriu
stefanceriu marked this pull request as ready for review September 3, 2026 13:11
@stefanceriu
stefanceriu requested a review from a team as a code owner September 3, 2026 13:11
@codspeed-hq

codspeed-hq Bot commented Sep 3, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 50 untouched benchmarks


Comparing verificationRequestMissingSecrets (5a6ba5d) with main (4fbc1e8)

Open in CodSpeed

@andybalaam andybalaam left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants