fix(shared_mobility): set initialSoc on EV-typed dummy routing vehicles#4899
Merged
nkuehnel merged 1 commit intoApr 29, 2026
Merged
Conversation
nkuehnel
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a sharing service uses an electric vehicle type (
HbefaTechnology="electricity"),getOrCreateAndAddDummyVehicle()creates a routing-only dummy vehicle with that type but without setting theinitialSocattribute.Since #4834,
GlobalElectricFleetpicks up all EV-typed vehicles fromscenario.getVehicles()and wraps them viaElectricVehicleSpecificationDefaultImpl, whose constructor readsinitialSoc. The missing attribute causes an NPE (null → double unboxing).Fix: Use
ElectricFleetUtils.isElectricVehicleType()andsetInitialSoc()to setinitialSoc = 1.0on the dummy vehicle when its type is electric. Adds ev contrib as a dependency of shared_mobility. The dummy is only used for replanning route calculations and never participates in the EV simulation, so the value has no functional impact.