Skip to content

N-13: fix misleading or incomplete comments #2125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
valera-grinenko-ai wants to merge 1 commit into
base: draft-v31
Choose a base branch
from
Open

N-13: fix misleading or incomplete comments #2125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion l1-contracts/contracts/bridge/asset-router/AssetRouterBase.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ abstract contract AssetRouterBase is IAssetRouterBase, Ownable2StepUpgradeable,
/// @dev send the burn message to the asset
/// @notice Forwards the burn request for specific asset to respective asset handler.
/// @param _chainId The chain ID of the ZK chain to which to deposit.
/// @param _nextMsgValue The L2 `msg.value` from the L1 -> L2 deposit transaction.
/// @param _nextMsgValue The L2 `msg.value` from the deposit or interop transaction.
/// @param _assetId The deposited asset ID.
/// @param _originalCaller The `msg.sender` address from the external call that initiated current one.
/// @param _transferData The encoded data, which is used by the asset handler to determine L2 recipient and amount. Might include extra information.
Expand Down
2 changes: 1 addition & 1 deletion l1-contracts/contracts/core/chain-asset-handler/ChainAssetHandlerBase.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ abstract contract ChainAssetHandlerBase is
if (zkChain == address(0)) {
revert ChainIdNotRegistered(bridgehubMintData.chainId);
}
// We want to allow any chain to be migrated,
// We want to allow any chain to be migrated, so we register it unconditionally.
IBridgehubBase(_bridgehub()).registerNewZKChain(bridgehubMintData.chainId, zkChain, false);
_messageRoot().addNewChain(bridgehubMintData.chainId, bridgehubMintData.batchNumber);
} else {
Expand Down
2 changes: 1 addition & 1 deletion l1-contracts/contracts/state-transition/chain-interfaces/IMigrator.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ interface IMigrator is IZKChainBase {
/// @notice Emitted when deposits are unpaused.
event DepositsUnpaused(uint256 chainId);

/// @notice Pauses deposits before initiating migration to the Gateway.
/// @notice Pauses deposits before initiating a chain migration (L1 → GW or GW → L1).
function pauseDepositsBeforeInitiatingMigration() external;

/// @notice Unpauses deposits, used after the chain is initialized
Expand Down