N-09: fix naming inconsistencies for v31#2127
Open
valera-grinenko-ai wants to merge 3 commits intomatter-labs:draft-v31from
Open
N-09: fix naming inconsistencies for v31#2127valera-grinenko-ai wants to merge 3 commits intomatter-labs:draft-v31from
valera-grinenko-ai wants to merge 3 commits intomatter-labs:draft-v31from
Conversation
The variable holds the resolved asset handler for the given assetId, which may be an L2 handler in interop (L2-to-L2) flows. The "l1" prefix is misleading since v31. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
valera-grinenko-ai
requested review from
StanislavBreadless,
kelemeno and
vladbochok
as code owners
Replace the outdated NotHyperchain() error with the existing NotAZKChain(address) error in requestL2TransactionToGatewayMailbox- WithBalanceChange. NotAZKChain already exists in L1ContractErrors and includes the caller address for better debuggability. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
No remaining references in the codebase after replacing with NotAZKChain. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
valera-grinenko-ai
changed the title
| import {IEIP7702Checker} from "contracts/state-transition/chain-interfaces/IEIP7702Checker.sol"; | ||
|
|
||
| import {AddressNotZero, ZeroAddress} from "contracts/common/L1ContractErrors.sol"; | ||
| import {AddressNotZero, NotAZKChain, ZeroAddress} from "contracts/common/L1ContractErrors.sol"; |
Collaborator
There was a problem hiding this comment.
it appears that this error is never tested, right? we added it here inside the imports and never ended up using it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addressed
NotHyperchain()withNotAZKChain(msg.sender)inMailbox.requestL2TransactionToGatewayMailboxWithBalanceChange— uses the existing error fromL1ContractErrorswhich follows current ZKChain terminology and includes the caller address for better debuggability. Removes the now-unusedNotHyperchaindefinition fromL1StateTransitionErrors.soll1AssetHandler→assetHandlerinAssetRouterBase._burn— the variable holds the resolved handler for the given assetId, which may be an L2 handler in interop (L2→L2) flows; the "l1" prefix is misleading since v31Test plan
forge buildpassesNotAZKChainis reverted with the correct sender address when caller is not the expected ZKChain🤖 Generated with Claude Code