N-08: use dynamic origin chain lookup for base token finalization#2128
Open
valera-grinenko-ai wants to merge 1 commit intomatter-labs:draft-v31from
Open
N-08: use dynamic origin chain lookup for base token finalization#2128valera-grinenko-ai wants to merge 1 commit intomatter-labs:draft-v31from
valera-grinenko-ai wants to merge 1 commit intomatter-labs:draft-v31from
Conversation
valera-grinenko-ai
requested review from
StanislavBreadless,
kelemeno and
vladbochok
as code owners
In handleFinalizeBaseTokenBridgingOnL2, replace hardcoded L1_CHAIN_ID with L2_NATIVE_TOKEN_VAULT.originChainId(baseTokenAssetId) for the _tokenOriginChainId parameter. A base token can originate from a chain other than L1 (e.g. a token first deployed on another L2). The initiate path (handleInitiateBaseTokenBridgingOnL2, line 269) already uses the dynamic NTV lookup — this makes the finalize path consistent. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
valera-grinenko-ai
force-pushed
the
pr/N-08-hardcoded-origin-chain-id
branch
from
da9d879 to
868e41b
Compare
valera-grinenko-ai
changed the title
StanislavBreadless
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
L1_CHAIN_IDwithL2_NATIVE_TOKEN_VAULT.originChainId(baseTokenAssetId)inL2AssetTracker.handleFinalizeBaseTokenBridgingOnL2handleInitiateBaseTokenBridgingOnL2, line 269) already uses the dynamic NTV lookup — this makes the finalize path consistentTest plan
forge buildpasses🤖 Generated with Claude Code