fix: pass passive false for touch events in listenOnTheHost#137
Merged
mattlewis92 merged 3 commits intomainfrom Mar 11, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
==========================================
+ Coverage 81.13% 81.27% +0.13%
==========================================
Files 5 6 +1
Lines 281 283 +2
Branches 59 61 +2
==========================================
+ Hits 228 230 +2
Misses 42 42
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mattlewis92
reviewed
Mar 11, 2026
| eventName === 'touchend' || | ||
| eventName === 'touchcancel'; | ||
| const source$ = isTouchEvent | ||
| ? fromEvent<T>(this.element.nativeElement, eventName, { passive: false }) |
Owner
There was a problem hiding this comment.
nit: move the ternary into the option like isTouchEvent ? { passive: false } : undefined)
Collaborator
Author
There was a problem hiding this comment.
Updated in 7bac69c
It now uses either { passive: false } or empty object {} as undefined isn't a valid argument
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On touch devices, the resize handle registers
touchstart/touchend/touchcancelviafromEvent()with no options. Browsers treat these as passive by default, so whenonMousedowncallsevent.preventDefault()the call is ignored and the console shows:Unable to preventDefault inside passive event listenerSolution
In
listenOnTheHost, pass{ passive: false }as the third argument tofromEvent()for touch events (touchstart,touchend,touchcancel) sopreventDefault()is allowed and the warning is removed.Changes
No behavior change for mouse events; touch resize continues to work and the passive-listener warning is resolved.