Pin GitHub release installer versions#852
Merged
Merged
Conversation
The old script looped through LLVM 9-15 trying clang+llvm-X-pc-linux-gnu.tar.xz
asset names that no longer exist. Replaced with a pinned version variable
($version=22.1.6) and the modern LLVM-{version}-Linux-{ARCH}.tar.xz /
LLVM-{version}-macOS-ARM64.tar.xz asset names. Now also recognized by
update-installer-versions.sh.
Replaces releases/latest/download/... with releases/download/$version/...
for 19 installers (38 files) so each script has an extractable version=
or set VERSION= line that update-installer-versions.sh can rewrite.
Drive-by fixes folded in:
- install-markdown-oxide.cmd pointed at atusy/markdown-oxide (404). Repointed
to Feel-ix-343/markdown-oxide upstream which does publish a Windows binary.
- install-systemd-lsp.{sh,cmd} had v2025.07.10 hardcoded mid-URL; pinned to
current latest v2026.04.21.
- install-typos-lsp.{sh,cmd} dropped the curl-redirect-to-learn-the-version
dance in favor of a pinned tag.
- install-omnisharp-lsp.{sh,cmd}: the script's local 'version' (dotnet --version
output) was renamed to 'dotnet_version' so the pinned release version can
coexist without shadowing.
biome and oxlint are left unchanged: biome's tag (@biomejs/biome@X.Y.Z) needs
URL encoding, and oxc-project/oxc publishes parallel apps_v*/crates_v* streams
where releases/latest is ambiguous. Both would need ad-hoc handling.
- install-clangd.sh: quote $cmd inside which (SC2086). - install-marksman.sh: quote $(uname -m) in test (SC2046).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
install-clangd.sh, which was broken because the oldclang+llvm-{ver}-pc-linux-gnu.tar.xzasset names no longer exist for current LLVM releases.Converts 19 other installers (38 files) from
releases/latest/download/...to a pinnedversion=/set VERSION=line plusreleases/download/$version/...URLs, so they can be kept current by a single sed pass over theversion=declarations.Drive-by fixes folded in:
install-markdown-oxide.cmdpointed at a 404 fork; repointed toFeel-ix-343/markdown-oxideupstream.install-systemd-lsp.{sh,cmd}had a hardcoded mid-URL version that was stale; now pinned to the current release.install-typos-lsp.{sh,cmd}drops the curl-redirect dance used to learn the latest tag.install-omnisharp-lsp.{sh,cmd}renames the script-localversion(dotnet runtime version) todotnet_versionso the pinned release version can coexist without shadowing.biome and oxlint are intentionally left as-is: biome's tag (
@biomejs/biome@X.Y.Z) needs URL encoding, andoxc-project/oxcpublishes parallelapps_v*andcrates_v*streams wherereleases/latestis ambiguous.