Skip to content

Feature/language service plugin#154

Draft
ivan-demchenko wants to merge 4 commits intomattpocock:mainfrom
ivan-demchenko:feature/language-service-plugin
Draft

Feature/language service plugin#154
ivan-demchenko wants to merge 4 commits intomattpocock:mainfrom
ivan-demchenko:feature/language-service-plugin

Conversation

@ivan-demchenko
Copy link
Copy Markdown

@ivan-demchenko ivan-demchenko commented Feb 6, 2023 •
edited
Loading

This is just a draft PR.
Closes #51

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 6, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: fc27b02

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ts-error-translator ❌ Failed (Inspect) Feb 7, 2023 at 7:54PM (UTC)

@ivan-demchenko ivan-demchenko force-pushed the feature/language-service-plugin branch from ff5fe31 to d8d0779 Compare February 7, 2023 11:51
@ivan-demchenko
Copy link
Copy Markdown
Author

ivan-demchenko commented Feb 7, 2023

First results
image

@ivan-demchenko ivan-demchenko force-pushed the feature/language-service-plugin branch from d8d0779 to 1d7332c Compare February 7, 2023 12:31
@ivan-demchenko ivan-demchenko force-pushed the feature/language-service-plugin branch from 1d7332c to 50eb9c0 Compare February 7, 2023 17:22
@ivan-demchenko ivan-demchenko force-pushed the feature/language-service-plugin branch from 50eb9c0 to 57fbc9c Compare February 7, 2023 19:50
@ivan-demchenko ivan-demchenko force-pushed the feature/language-service-plugin branch from 57fbc9c to fc27b02 Compare February 7, 2023 19:53
ivan-demchenko
ivan-demchenko commented Feb 7, 2023
View reviewed changes
packages/language-service-plugin/src/index.ts
@@ -0,0 +1,53 @@
import { parseErrors } from '@total-typescript/error-translation-engine';
Copy link
Copy Markdown
Author

@ivan-demchenko ivan-demchenko Feb 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattpocock I'm not sure if this is the right function to import here

ivan-demchenko
ivan-demchenko commented Feb 8, 2023
View reviewed changes
packages/engine/package.json
"license": "MIT",
"main": "./src/index.ts",
"types": "./src/index.ts",
"main": "./out/index.js",
Copy link
Copy Markdown
Author

@ivan-demchenko ivan-demchenko Feb 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattpocock I needed this change to make plugin bundling work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

As a "Language Service Plugin" to have broad support for IDEs besides vscode

2 participants

@ivan-demchenko @raqystyle