Skip to content

DHCP ServiceInfo deprecation in 2025.2#74

Merged
mattrayner merged 16 commits into
mattrayner:masterfrom
jamesonuk:master
Jun 3, 2025
Merged

DHCP ServiceInfo deprecation in 2025.2#74
mattrayner merged 16 commits into
mattrayner:masterfrom
jamesonuk:master

Conversation

@jamesonuk

Copy link
Copy Markdown
Contributor

Resolves #73
An internal class has been moved in HA so it just changing the package. Looks to be effective from 2025.2 so have bumped minimum version in HACS

mattrayner
mattrayner previously approved these changes May 12, 2025

@mattrayner mattrayner left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a look at the tests that are failing later this week and cut a release, unless you are able to resolve them first?

@jamesonuk

Copy link
Copy Markdown
Contributor Author

I'll take a look at the tests that are failing later this week and cut a release, unless you are able to resolve them first?

I was a bit silly and thought it would just a one liner so haven't setup a proper dev environment so I have been a bit lazy and just seeing what GitHub workflow is spitting out.... Can't be many left now.... Probably worth rebasing this branch before merging....

@jamesonuk

Copy link
Copy Markdown
Contributor Author

I will try and take a look at some point but it is structural changes now rather than just moving constants.
https://developers.home-assistant.io/blog/2024/11/04/reauth-reconfigure-entry-id/

so looking at
https://github.com/home-assistant/core/blob/d471de5645b8bf02d500dbddb6b9120578c15c55/homeassistant/config_entries.py#L1200

the result looks to be swallowed up there so he check on results in the test are failing.

@jamesonuk

Copy link
Copy Markdown
Contributor Author

So I did the sensible thing and actually put this on my dev machine and set it up properly.....
Interestingly the HA docs are still outdated https://developers.home-assistant.io/docs/core/integration-quality-scale/rules/config-flow-test-coverage/ but I managed to pull apart what they are doing in some of the internal integrations.

There is one check I commented out (assert result["type"] == FlowResultType.FORM) as there is no type in here (but I haven't got into the details as I kind of figured this test is slightly moot?

This PR is a mess.... Not sure what you want to about that test above, remove it try and rework it? and what what you to do about PR. Happy to clean this up and do a force push or to close this PR and create a new clean one

@mattrayner mattrayner left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for updating this, I'll cut a new release of this today

@mattrayner mattrayner merged commit be9dae8 into mattrayner:master Jun 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecation warning for DhcpServiceInfo in 2025.2

2 participants