DHCP ServiceInfo deprecation in 2025.2#74
Conversation
mattrayner
left a comment
There was a problem hiding this comment.
I'll take a look at the tests that are failing later this week and cut a release, unless you are able to resolve them first?
I was a bit silly and thought it would just a one liner so haven't setup a proper dev environment so I have been a bit lazy and just seeing what GitHub workflow is spitting out.... Can't be many left now.... Probably worth rebasing this branch before merging.... |
|
I will try and take a look at some point but it is structural changes now rather than just moving constants. the result looks to be swallowed up there so he check on results in the test are failing. |
|
So I did the sensible thing and actually put this on my dev machine and set it up properly..... There is one check I commented out ( This PR is a mess.... Not sure what you want to about that test above, remove it try and rework it? and what what you to do about PR. Happy to clean this up and do a force push or to close this PR and create a new clean one |
mattrayner
left a comment
There was a problem hiding this comment.
Thanks so much for updating this, I'll cut a new release of this today
Resolves #73
An internal class has been moved in HA so it just changing the package. Looks to be effective from 2025.2 so have bumped minimum version in HACS