Return the correct cable connection status during pending/offline states#77
Draft
jeverley wants to merge 4 commits into
Draft
Return the correct cable connection status during pending/offline states#77jeverley wants to merge 4 commits into
jeverley wants to merge 4 commits into
Conversation
- Ensures that the cable connection binary sensor remains 'connected' after a command is issued from HA to the pod cloud - Currently it switches to unplugged whilst the pod state is 'Pending' - The cable binary sensor now returns unknown rather than Unplugged if the device is offline
- Added return types for is_on properties - Removed unused imports
Author
|
I'll update the tests for this shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR amends the handling for the cable connection binary sensor to ensure it is handled consistently during pending/offline states, currently it switches to unplugged whilst the pod status is pending/offline.
What's changed
connectedproperty checks the reported pod statuses rather than entity state to confirm if the cable is connected, this ensures it remainson(connected) after a command is issued from Home Assistant to the Pod Point cloudunknownrather thanoff(unplugged) if the device is offline