Update grapesjs compatibility (Mautic 4)#50
Open
LordRembo wants to merge 49 commits intomautic:4.xfrom
Open
Conversation
Add compatibility with CKEditor 5
This was referenced Jan 30, 2024
…ways-spinning Fix the issue the loading spinner is always spinning
…bo/grapesjs-preset-mautic into update-grapesjs-compatibility-m5 + fix merge # Conflicts: # dist/buttons/buttonApply.command.js # dist/buttons/buttons.service.js
… traits instead, so it won't try to use a non-existing Node
… ones, but make it readable
…g to hardcode padding, so layout matches the other blocks in the email template
…e output of what will be rendered in the mail itself.
…compatibility-m4 + fix merge issues (remove the CKE5 stuff) # Conflicts: # dist/blocks.js # dist/buttons.js # dist/buttons/buttonApply.command.js # dist/buttons/buttons.service.js # dist/dynamicContent/dynamicContent.blocks.js # dist/dynamicContent/dynamicContent.domcomponents.js # src/buttons.js # src/dynamicContent/dynamicContent.domcomponents.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registering your custom components using the legacy method breaks when updating GrapesJS to release 0.20.1. Need this to be able to upgrade GrapesJS in the GrapesJSBuilderBundle.
there is a PR for M5
there's a PR for M5 with the recent CKE5 changes, this has prio
To test:
npm i grapesjs-preset- mautic@github:LordRembo/grapesjs-preset-mautic#update-grapesjs-m4inside that bundlenpm run build