Skip to content

messagix/instagram: treat missing Instagram thread as already deleted #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iFixRobots wants to merge 1 commit into
base: main
Choose a base branch
from
Open

messagix/instagram: treat missing Instagram thread as already deleted #263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion pkg/messagix/instagram.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ import (
"go.mau.fi/mautrix-meta/pkg/messagix/useragent"
)

// ErrIGThreadNotFound is returned when a route definition request succeeds
// but the thread_fbid is missing, indicating the thread no longer exists on Instagram.
var ErrIGThreadNotFound = errors.New("instagram thread not found")

// specific methods for insta api, not socket related
type InstagramMethods struct {
client *Client
Expand Down Expand Up @@ -255,7 +259,7 @@ func (ig *InstagramMethods) fetchRouteDefinition(ctx context.Context, threadID s
}
threadFBID := routeDefResp.Payload.Result.Exports.RootView.Props.ThreadFBID
if threadFBID == "" {
return "", fmt.Errorf("thread_fbid not found in route definition response for thread %s", threadID)
return "", fmt.Errorf("%w in route definition response for thread %s", ErrIGThreadNotFound, threadID)
}

zerolog.Ctx(ctx).Info().
Expand All @@ -269,6 +273,11 @@ func (ig *InstagramMethods) fetchRouteDefinition(ctx context.Context, threadID s
func (ig *InstagramMethods) DeleteThread(ctx context.Context, threadID string) error {
id, err := ig.fetchRouteDefinition(ctx, threadID)
if err != nil {
if errors.Is(err, ErrIGThreadNotFound) {
zerolog.Ctx(ctx).Warn().Err(err).Str("thread_id", threadID).
Msg("Thread not found on Instagram, assuming already deleted")
return nil
}
return fmt.Errorf("failed to fetch route definition for thread %s: %w", threadID, err)
}
igVariables := &graphql.IGDeleteThreadGraphQLRequestPayload{
Expand Down
Loading