Skip to content

Respect the .gitignore and .mdbookignore files#111

Draft
Bergmann89 wants to merge 1 commit intomax-heller:mainfrom
Bergmann89:main
Draft

Respect the .gitignore and .mdbookignore files#111
Bergmann89 wants to merge 1 commit intomax-heller:mainfrom
Bergmann89:main

Conversation

@Bergmann89
Copy link
Copy Markdown

If you use the root directory of the repository as source directory for mdbook, mdbook-pandoc will copy all files, including the book directory where the output is rendered to, to the output directory. This result in an infinite loop until the disk is full, or the paths are too long to be handled.

mdbook has a not yet merged PR to have a separate .mdbookignore file similar to .gitignore (see here).

This pull requests implements support for the .mdbookignore and the .gitignore file.

@Bergmann89 Bergmann89 force-pushed the main branch 2 times, most recently from a2bdd10 to adbf35f Compare August 21, 2024 14:58
@max-heller
Copy link
Copy Markdown
Owner

Thanks for the review! I'll wait for the mdbook PR to be merged before reviewing closely.

Can we use the recursive iterator provided by ignore instead of having a recursive copy function?

@Bergmann89
Copy link
Copy Markdown
Author

Thanks for the review! I'll wait for the mdbook PR to be merged before reviewing closely.

Alright 👍

Can we use the recursive iterator provided by ignore instead of having a recursive copy function?

Sure. I will add this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants