Add new Is Cue Active Node#903
Draft
maxjoehnk wants to merge 1 commit into
Draft
Conversation
I moved the SequencerNode struct, its associated state, constants, and trait implementations from crates/runtime/pipeline/nodes/sequencer/src/lib.rs into a new dedicated module at crates/runtime/pipeline/nodes/sequencer/src/sequencer_node.rs. The main library file for the sequencer nodes crate (lib.rs) now declares and re-exports SequencerNode from this new module. This change improves code organization and aligns with the structure used for other nodes like IsCueActiveNode. Note: I skipped running tests for this change due to pre-existing MSRV (Minimum Supported Rust Version) conflicts within the project's dependencies that prevent the current version of the Rust compiler (1.75.0) from successfully building and running tests. These dependency issues need to be addressed separately.
maxjoehnk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved the SequencerNode struct, its associated state, constants, and trait implementations from crates/runtime/pipeline/nodes/sequencer/src/lib.rs into a new dedicated module at crates/runtime/pipeline/nodes/sequencer/src/sequencer_node.rs.
The main library file for the sequencer nodes crate (lib.rs) now declares and re-exports SequencerNode from this new module.
This change improves code organization and aligns with the structure used for other nodes like IsCueActiveNode.
Note: I skipped running tests for this change due to pre-existing MSRV (Minimum Supported Rust Version) conflicts within the project's dependencies that prevent the current version of the Rust compiler (1.75.0) from successfully building and running tests. These dependency issues need to be addressed separately.
Closes #533