Skip to content

✨ [#529] Add filtering by subIdentificatorVan in partijen en…#592

Merged
OlhaZahoruiko merged 1 commit intomasterfrom
feature/529-subidentificator-filter
Apr 10, 2026
Merged

✨ [#529] Add filtering by subIdentificatorVan in partijen en…#592
OlhaZahoruiko merged 1 commit intomasterfrom
feature/529-subidentificator-filter

Conversation

@OlhaZahoruiko
Copy link
Copy Markdown
Contributor

@OlhaZahoruiko OlhaZahoruiko commented Mar 31, 2026

…dpoint

Fixes #529

Changes

[Describe the changes here]

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 31, 2026

Codecov Report

❌ Patch coverage is 90.80460% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.71%. Comparing base (774917c) to head (635b797).

Files with missing lines Patch % Lines
...ponents/klantinteracties/api/filterset/partijen.py 66.66% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #592      +/-   ##
==========================================
- Coverage   97.75%   97.71%   -0.05%     
==========================================
  Files         231      232       +1     
  Lines       13502    13588      +86     
==========================================
+ Hits        13199    13277      +78     
- Misses        303      311       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OlhaZahoruiko OlhaZahoruiko force-pushed the feature/529-subidentificator-filter branch from 897a1f8 to 58b563d Compare March 31, 2026 13:09
@OlhaZahoruiko OlhaZahoruiko marked this pull request as ready for review March 31, 2026 13:14
@OlhaZahoruiko OlhaZahoruiko force-pushed the feature/529-subidentificator-filter branch from e842338 to 3a97fdd Compare March 31, 2026 14:52
@OlhaZahoruiko OlhaZahoruiko requested a review from stevenbal March 31, 2026 14:52
@OlhaZahoruiko OlhaZahoruiko force-pushed the feature/529-subidentificator-filter branch from 146d3ca to 8b210d7 Compare April 9, 2026 10:38
@OlhaZahoruiko OlhaZahoruiko requested a review from stevenbal April 9, 2026 10:42
@stevenbal stevenbal self-assigned this Apr 10, 2026
@stevenbal stevenbal force-pushed the feature/529-subidentificator-filter branch from 8b210d7 to 1414ea4 Compare April 10, 2026 09:19
@stevenbal
Copy link
Copy Markdown
Collaborator

@OlhaZahoruiko sorry, I was wrong in my first PR feedback 🤦

I was confused about the usage of subIdentificatorVan__ filters and partijIdentificator__, I think your initial version was correct, so I changed it back to that so that you can find a specific branch of a company by:

  • partijIdentificator parameters: the branch specific info
  • subIdentificatorVan: the info related to the KVK number

@stevenbal stevenbal force-pushed the feature/529-subidentificator-filter branch from 1414ea4 to 635b797 Compare April 10, 2026 09:22
@stevenbal stevenbal mentioned this pull request Apr 10, 2026
@OlhaZahoruiko OlhaZahoruiko merged commit cd48545 into master Apr 10, 2026
32 checks passed
@OlhaZahoruiko OlhaZahoruiko deleted the feature/529-subidentificator-filter branch April 10, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Additional filtering using 'subIdentificatorVan' data to retrieve partijen to be able to retrieve a vestiging partij for a certain related KVK number

3 participants