Refactor popup dialogs#30
Open
mborik wants to merge 2 commits into
Open
Conversation
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor popup dialogs to use uniform event handler from main thread, and get rid of while-loops within other parts of code.
Suggested steps:
GUI_MENU_TYPEwith these dialog types (_ABOUT,_QUERY,_MESSAGE_BOX,_EDITBOX)GUI_EDITBOX_DATAinto UserInterface.h with all input parameters (title,description,buffer,maxLength,decimal), current state variables (x,y,w,len,cursor,result,atTheEnd,change) andsigslot::signal2<char *, BYTE> callback(sendingbufferandresult)KeyhandlerEditBox,KeyhandlerCommonDialogfor About and MessageBox, andKeyhandlerQueryDialog) and integrate intoMenuHandleKeyDrawEditBox,DrawAboutDialog,DrawMessageBox, andDrawQueryDialog) and integrate intoMenuOpenswitchThis is a prerequisite for the proper execution of the Emscripten/WASM build, where an additional infinite loop for polling events leads to the entire application becoming hung.