Modularize - allow system dependencies#4
Closed
arntanguy wants to merge 4 commits intomc-rtc:mainfrom
Closed
Conversation
Contributor
Author
|
Scaling issue reported upstream to glfw/glfw#2839 The following works as expected but with the default env variables it fails |
- This works in nix for now - For magnum plugins, we need to symlink them all into the same store path and provide the directory through a cmake variable (this is done by Nix) - ImGuizmo still not done
arntanguy
force-pushed
the
topic/nix-modular
branch
from
8f21d05 to
d12c95f
Compare
arntanguy
force-pushed
the
topic/nix-modular
branch
2 times, most recently
from
3945632 to
5b6fe23
Compare
Contributor
Author
|
I tried supporting this on non nix build, but gave up.
Thus for now I'll merge this into a |
Contributor
Author
|
Rebased into a single commit (for easier rebasing) and pushed to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseeds / complements #3
This PR lets us build
mc_rtc-magnumagainst its dependencies installed externally:mc_rtc-imgui: Standalone install mc_rtc-imgui#25magnum,magnum-plugins,magnum-integrationshave been packaged inmc-rtc/nixpkgsimguiandimplotalready have officialnixpkgssupportThe intent is:
FIXME: it's working in nix, but:
TODO:
I took a brutal approach here and nuked all submodules and their use thereof from the repo. But I probably need to re-introduce a way to have optional local install of all dependencies for non-nix systems, probably some straightforward FetchContent in case the system dependency is unavailable.