fix: make unknown attribute diagnostic opt-in#357
Merged
Conversation
The schema-unknown-attribute diagnostic validated inline attributes against an allow-list built only from installed extension _schema.yml files. Quarto Wizard has no built-in schema for Quarto/Pandoc/revealjs internals, so valid attributes such as width on .column were reported as unknown whenever an extension shipped an attributes._any block. Gate the diagnostic behind a new quartoWizard.lint.unknownAttributes setting, disabled by default, so unknown attributes are ignored unless the user opts in. Closes #356
Bump dev and runtime dependencies to their latest compatible versions. Hold tar at 7.5.15: 7.5.16 surfaces a late, unhandled Z_STREAM_ERROR from minizlib when an extraction is aborted mid-stream (the security abort path in archive/tar.ts), which would escape the extractor's try/catch. Pin @types/archiver to v7 to match the held archiver v7 runtime. Both are added to the update:deps reject list.
mcanouil
added
Type: Bug 🐛
mcanouil
removed
the
Type: Dependencies ⬆️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inline attribute linter validated attributes against an allow-list built only from installed extension
_schema.ymlfiles. Quarto Wizard ships no schema for Quarto, Pandoc, or revealjs internals, so valid attributes such aswidthon.columnwere reported asUnknown attributewhenever an installed extension contributed anattributes._anyblock.The
schema-unknown-attributediagnostic is now gated behind a newquartoWizard.lint.unknownAttributessetting, disabled by default. With the default, unknown attributes are ignored; enabling the setting restores the diagnostic for authors working against extensions that declare a complete attribute set. Open documents re-validate when the setting changes.Also updates dependencies to their latest compatible versions.
taris held at 7.5.15 because 7.5.16 emits an unhandledZ_STREAM_ERRORwhen an extraction is aborted mid-stream, and@types/archiveris held at v7 to match the v7archiverruntime; both are added to theupdate:depsreject list.Closes #356