refactor(types): migrate from tsd to tstyche + CI matrix bump - #136
Open
Puppo wants to merge 6 commits into
Open
refactor(types): migrate from tsd to tstyche + CI matrix bump#136Puppo wants to merge 6 commits into
Puppo wants to merge 6 commits into
Conversation
- Replace tsd devDependency with tstyche ^7.1.0 - Update test:types and test scripts to invoke tstyche - Rename mqemitter-redis.test-d.ts to mqemitter-redis.tst.ts - Translate assertions: - expectType<T>(value) -> expect(value).type.toBe<T>() - expectError(value) -> expect(value).type.not.toBeCallableWith(...) - Wrap assertions in describe/it blocks for a structured, readable report - Add root tsconfig.json so tstyche (module: NodeNext) can resolve the existing 'export = MQEmitterRedis' .d.ts via esModuleInterop Refs: nearform/fastify-slow-down#625
Add 26.x to the node-version matrix in .github/workflows/ci.yml so we catch regressions on the upcoming Current release line early. Node 26 is not LTS yet (it ships as Current in May 2026 and will become LTS in October 2026) but the package's engines field already accepts it. Also includes the companion CI housekeeping that was already staged: - Bump actions/checkout and actions/setup-node from v4 to v6 - Swap Redis 7.2 for 8.0 in the services image matrix (still covers the 7.x -> 8.x major-version boundary alongside 7.4)
Switch the redis services matrix from pinned [7.4, 8.0] to floating [7, 8] so the image tag always points to the latest 7.x and 8.x releases on Docker Hub. Trade-off: a CI run is no longer bit-exact reproducible for the Redis image, but we never have to bump the matrix manually when a new minor ships.
Auto-formatting nudge: the 6379:6379 port mapping was over-indented under the services.redis block. Two-space dash matches the rest of the YAML style.
tstyche baseline TSConfig (esModuleInterop: true) handles the export = MQEmitterRedis declaration correctly without a root tsconfig.json. BREAKING CHANGE: types field in package.json now points to types/mqemitter-redis.d.ts
Puppo
marked this pull request as ready for review
June 17, 2026 15:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate type tests from
tsdtotstyche, move the type files into atypes/folder, and upgrade the CI matrix.