fix: security hardening — amount validation, address validation, chain ID rejection#26
Open
livingproofdev25 wants to merge 1 commit intomcpdotdirect:mainfrom
Open
fix: security hardening — amount validation, address validation, chain ID rejection#26livingproofdev25 wants to merge 1 commit intomcpdotdirect:mainfrom
livingproofdev25 wants to merge 1 commit intomcpdotdirect:mainfrom
Conversation
…ion, chain ID rejection Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validateAmount()that rejects non-numeric, negative, zero, and excessively large amounts beforeparseEther()/parseUnits()/BigInt(). Applied totransferETH,transferERC20,approveERC20, andtransferERC1155.validateAddressOrEns()that validates0x+ 40 hex char format while allowing ENS names (containing.) to pass through. Applied toread_contract,write_contract,transfer_native, andtransfer_erc20tool handlers.resolveChainId()andgetChain()now throw errors for unrecognized networks instead of silently falling back to Ethereum mainnet, preventing accidental transactions on the wrong chain.Test plan
npx tsc --noEmitpassestransfer_nativerejects negative amounts (e.g.,"-1")read_contractrejects malformed addresses (e.g.,"0xinvalid")"vitalik.eth"still work"typo") throws instead of defaulting to mainnet[XaX] https://XautomateX.com