Conversation
…ANIMATION_MS are now honored Both options are documented in docs/OPTIMIZE.md as the CPU tuning knob for the WPM animations, but luna.c and bongo_cat.c used hardcoded cycle times (200ms walk/run). Luna now derives all states from the Kconfig value (idle runs at 3x the base), Bongo Cat uses it for the fast state. Note: this changes the effective default from 200ms to the Kconfig default of 300ms. Peripheral builds with ANIMATION_PERIPHERAL_WPM fall back to 300ms since the symbol only exists on central.
delneet
marked this pull request as ready for review
July 3, 2026 09:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CONFIG_NICE_OLED_WIDGET_WPM_LUNA_ANIMATION_MSandCONFIG_NICE_OLED_WIDGET_WPM_BONGO_CAT_ANIMATION_MSexist in Kconfig and are documented indocs/OPTIMIZE.mdas the CPU tuning knob for these animations, but neither widget reads them:luna.candbongo_cat.cuse hardcoded cycle times (200 ms for walk/run — ~10 redraws/s while typing fast).Change
luna.c: all states derive from the Kconfig value; idle runs at 3x the base so the sitting dog stays calm (default 300 → idle 900 ms, close to the previous 960 ms).bongo_cat.c: the fast state (the one that dominates CPU while typing) uses the Kconfig value; idle/slow/mid keep their existing slow timings.Note — effective default changes from the hardcoded 200 ms to the Kconfig default of 300 ms (slightly slower, cheaper). Users can restore the old feel with
..._ANIMATION_MS=200.luna.cfalls back to 300 ms when the symbol is undefined, since the option only exists on the central but the file is also compiled forNICE_OLED_WIDGET_ANIMATION_PERIPHERAL_WPM. (Unrelated: that peripheral config currently fails to link on ZMK v0.3.0 becauseZMK_WPMneeds keycode events that don't exist on the peripheral — pre-existing, reproduced with unmodifiedmain.)Verification
Built against ZMK v0.3.0 (
nice_nano_v2): default config (Bongo Cat) and a Luna config with..._LUNA_ANIMATION_MS=400; the value lands in.configand builds are clean.