-
Notifications
You must be signed in to change notification settings - Fork 23.2k
Document Wasm SIMD arithmetic instructions #43583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chrisdavidmills
wants to merge
24
commits into
mdn:main
Choose a base branch
from
chrisdavidmills:wasm-simd-3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
874b015
Document Wasm SIMD arithmetic instructions
chrisdavidmills 9c44291
Add more SIMD information to numeric values
chrisdavidmills b4185e3
Merge branch 'main' into wasm-simd-3
chrisdavidmills 1543148
Arithmetic instruction progress
chrisdavidmills 527741b
More bitwise/arithmetic progress
chrisdavidmills e48fa06
Add v128 logic instructions
chrisdavidmills 5f07945
correct arithmetic casin
chrisdavidmills 7cd395b
Fix i32/i64 type prefix in integer comparison binary examples
eqrion 2d214a3
Fix i8x16.shr_s and i8x16.shr_u binary encoding examples
eqrion dc4c126
Fix 00x0 typo in load64_lane binary encoding example
eqrion 9c7c2ba
Fix div binary encoding examples
eqrion 4a03b5d
Fix const binary encoding examples
eqrion a87d6bd
Fix shr_s example description: i8x16 -> i16x8
eqrion e6b5e23
Fix shr_u example: i8x16 -> i16x8, extract_lane_s -> extract_lane_u
eqrion 62d90ff
Fix ceil/floor SIMD example type: i32x4 -> f32x4
eqrion c550058
Fix bitmask description to be accurate for all lane types
eqrion 9752a16
Fix all_true description: "all bits" -> "all lanes"
eqrion d5f36ff
Fix gt_u link in numeric index pointing to gt_s
eqrion 0faa6c1
Remove placeholder (#) links for add_sat_s/add_sat_u
eqrion d4615dc
Merge pull request #14 from eqrion/simd-review
chrisdavidmills 486d716
Merge branch 'main' into wasm-simd-3
chrisdavidmills 6af370a
Remove empty links for now
chrisdavidmills e5b03d0
Add explanations of what the output SIMD values contain.
chrisdavidmills e993159
More fixes from Hamish review
chrisdavidmills File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason you chose "in our" rather than "in the following", "in the", or "in this"? Feels inconsistent/odd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reason at all. I don't think this is a big enough issue to worry about. It feels slightly more conversational than usual, but otherwise OK.