Skip to content

fix: add reservations for current line item to available quantity #10801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kevinfurmanski wants to merge 4 commits into from
Closed

fix: add reservations for current line item to available quantity #10801

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7cd0046
fix: add reservations for current line item to available quantity
kevinfurmanski Jan 2, 2025
d379aea
fix: line item should be string[]
kevinfurmanski Jan 2, 2025
34cf931
Merge branch 'v1.x' into fix/create-fulfillment-with-last-item
riqwan Jan 30, 2025
e7a655e
Merge branch 'v1.x' into fix/create-fulfillment-with-last-item
riqwan Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions packages/admin-ui/ui/src/domain/orders/details/create-fulfillment/item-table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import ImagePlaceholder from "../../../../components/fundamentals/image-placehol
import InputField from "../../../../components/molecules/input"
import { LineItem } from "@medusajs/medusa"
import clsx from "clsx"
import { useAdminVariantsInventory } from "medusa-react"
import { useAdminVariantsInventory, useAdminReservations } from "medusa-react"
import { useFeatureFlag } from "../../../../providers/feature-flag-provider"

export const getFulfillableQuantity = (item: LineItem): number => {
Expand Down Expand Up @@ -77,10 +77,21 @@ const FulfillmentLine = ({
isFeatureEnabled("inventoryService") &&
isFeatureEnabled("stockLocationService")

const { variant, isLoading, refetch } = useAdminVariantsInventory(
item.variant_id as string,
{ enabled: isLocationFulfillmentEnabled }
)
const {
variant,
isLoading: isInventoryLoading,
refetch,
} = useAdminVariantsInventory(item.variant_id as string, {
enabled: isLocationFulfillmentEnabled,
})

const { reservations, isLoading: isReservationsLoading } =
useAdminReservations({
location_id: locationId,
line_item_id: [item.id],
})

const isLoading = isInventoryLoading || isReservationsLoading

const hasInventoryItem = !!variant?.inventory.length

Expand Down Expand Up @@ -112,8 +123,13 @@ const FulfillmentLine = ({
return {}
}

const reservedQuantityForLineItem = reservations.reduce(
(q, r) => q + r.quantity,
0
)

return {
availableQuantity: locationInventory.available_quantity,
availableQuantity: locationInventory.available_quantity + reservedQuantityForLineItem,
inStockQuantity: locationInventory.stocked_quantity,
}
}, [
Expand Down