fix(utils): Typecasting non-text fields in FTS - #12729
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
olivermrbl
requested review from
thetutlage
and removed request for
kasperkristensen and
sradevski
June 13, 2025 08:27
Contributor
Author
|
@adrien2p, let me know if this makes sense. |
adrien2p
approved these changes
Jun 13, 2025
adrien2p
left a comment
adrien2p
left a comment
Contributor
There was a problem hiding this comment.
Yes I think it make sense to have
adrien2p
reviewed
Jun 13, 2025
olivermrbl
force-pushed
the
fix/non-text-searchables
branch
from
June 13, 2025 09:42
291b6c8 to
cc15813
Compare
|
Contributor
|
Related SUP-1838 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix the typecasting for non-text properties in our FTS
Why
Currently, the
::textcasting is considered part of the column name leading to the following error (in the case of orders):How
Use raw typecasting flavor introduced in MikroORM v6
mikro-orm/mikro-orm#4774 (comment)
Separately, this PR also adds support for defining the
autoincrementmodifier as searchable.