fix(utils): build query withDeleted remove auto detection - #12788
Merged
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
adrien2p
changed the title
Contributor
Author
|
@olivermrbl would you have a minute sometime today to discuss this bad boy? |
Contributor
|
@adrien2p, let's do it. Ping me whenever |
olivermrbl
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Currently, filtering data providing a
deleted_atvalue will automatically apply thewithDeletedflag which in turns remove the default constraint apply to all queriesdeleted_at: null. The problem is that it does not account for the value assign todeleted_atleading to inconsistent behaviour depending on the value. e.g filtering withdeleted_at: { $eq: null }where the expectation is to only filter the non deleted record will end up returning deleted record as well by applying thewithDeletedfilters.This pr revert this auto detection if favor of the user providing
withDeletedexplicitly, as it is already supported , plus the filters.Further more, some integration tests demonstrate how to filter deleted records (e.g product) from the api. While the api did not properly support it, this pr adds support to pass with_deleted flags to the query and being handled accordingly to our api support. Validators have been updated and product list end point benefit from it. Also, the list config type was already accepting such value which I have translated to the remote query config.
Also, since the previous pr was adjusting the product types, I ve adjusted them to match the expectation