fix(core-flows,workflows-sdk): compensate account holders only when its created - #12825
Merged
Conversation
🦋 Changeset detectedLatest commit: 3c7447e The changes in this PR will be included in the next version bump. This PR includes changesets to release 69 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Skipped Deployments
|
Contributor
Author
|
/snapshot-this |
sradevski
approved these changes
Jun 25, 2025
Contributor
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/admin-bundler@2.8.6-snapshot-20250625103013yarn add @medusajs/admin-sdk@2.8.6-snapshot-20250625103013yarn add @medusajs/admin-shared@2.8.6-snapshot-20250625103013yarn add @medusajs/admin-vite-plugin@2.8.6-snapshot-20250625103013yarn add @medusajs/dashboard@2.8.6-snapshot-20250625103013yarn add create-medusa-app@2.8.6-snapshot-20250625103013yarn add @medusajs/cli@2.8.6-snapshot-20250625103013yarn add medusa-dev-cli@2.8.6-snapshot-20250625103013yarn add @medusajs/medusa-oas-cli@2.8.6-snapshot-20250625103013yarn add @medusajs/core-flows@2.8.6-snapshot-20250625103013yarn add @medusajs/framework@2.8.6-snapshot-20250625103013yarn add @medusajs/js-sdk@2.8.6-snapshot-20250625103013yarn add @medusajs/modules-sdk@2.8.6-snapshot-20250625103013yarn add @medusajs/orchestration@2.8.6-snapshot-20250625103013yarn add @medusajs/types@2.8.6-snapshot-20250625103013yarn add @medusajs/utils@2.8.6-snapshot-20250625103013yarn add @medusajs/workflows-sdk@2.8.6-snapshot-20250625103013yarn add @medusajs/icons@2.8.6-snapshot-20250625103013yarn add @medusajs/ui@4.0.16-snapshot-20250625103013yarn add @medusajs/ui-preset@2.8.6-snapshot-20250625103013yarn add @medusajs/medusa@2.8.6-snapshot-20250625103013yarn add @medusajs/telemetry@2.8.6-snapshot-20250625103013yarn add @medusajs/test-utils@2.8.6-snapshot-20250625103013yarn add @medusajs/analytics@2.8.6-snapshot-20250625103013yarn add @medusajs/api-key@2.8.6-snapshot-20250625103013yarn add @medusajs/auth@2.8.6-snapshot-20250625103013yarn add @medusajs/cache-inmemory@2.8.6-snapshot-20250625103013yarn add @medusajs/cache-redis@2.8.6-snapshot-20250625103013yarn add @medusajs/cart@2.8.6-snapshot-20250625103013yarn add @medusajs/currency@2.8.6-snapshot-20250625103013yarn add @medusajs/customer@2.8.6-snapshot-20250625103013yarn add @medusajs/event-bus-local@2.8.6-snapshot-20250625103013yarn add @medusajs/event-bus-redis@2.8.6-snapshot-20250625103013yarn add @medusajs/file@2.8.6-snapshot-20250625103013yarn add @medusajs/fulfillment@2.8.6-snapshot-20250625103013yarn add @medusajs/index@2.8.6-snapshot-20250625103013yarn add @medusajs/inventory@2.8.6-snapshot-20250625103013yarn add @medusajs/link-modules@2.8.6-snapshot-20250625103013yarn add @medusajs/locking@2.8.6-snapshot-20250625103013yarn add @medusajs/notification@2.8.6-snapshot-20250625103013yarn add @medusajs/order@2.8.6-snapshot-20250625103013yarn add @medusajs/payment@2.8.6-snapshot-20250625103013yarn add @medusajs/pricing@2.8.6-snapshot-20250625103013yarn add @medusajs/product@2.8.6-snapshot-20250625103013yarn add @medusajs/promotion@2.8.6-snapshot-20250625103013yarn add @medusajs/analytics-local@2.8.6-snapshot-20250625103013yarn add @medusajs/analytics-posthog@2.8.6-snapshot-20250625103013yarn add @medusajs/auth-emailpass@2.8.6-snapshot-20250625103013yarn add @medusajs/auth-github@2.8.6-snapshot-20250625103013yarn add @medusajs/auth-google@2.8.6-snapshot-20250625103013yarn add @medusajs/file-local@2.8.6-snapshot-20250625103013yarn add @medusajs/file-s3@2.8.6-snapshot-20250625103013yarn add @medusajs/fulfillment-manual@2.8.6-snapshot-20250625103013yarn add @medusajs/locking-postgres@2.8.6-snapshot-20250625103013yarn add @medusajs/locking-redis@2.8.6-snapshot-20250625103013yarn add @medusajs/notification-local@2.8.6-snapshot-20250625103013yarn add @medusajs/notification-sendgrid@2.8.6-snapshot-20250625103013yarn add @medusajs/payment-stripe@2.8.6-snapshot-20250625103013yarn add @medusajs/region@2.8.6-snapshot-20250625103013yarn add @medusajs/sales-channel@2.8.6-snapshot-20250625103013yarn add @medusajs/stock-location@2.8.6-snapshot-20250625103013yarn add @medusajs/store@2.8.6-snapshot-20250625103013yarn add @medusajs/tax@2.8.6-snapshot-20250625103013yarn add @medusajs/user@2.8.6-snapshot-20250625103013yarn add @medusajs/workflow-engine-inmemory@2.8.6-snapshot-20250625103013yarn add @medusajs/workflow-engine-redis@2.8.6-snapshot-20250625103013
|
carlos-r-l-rodrigues
approved these changes
Jun 25, 2025
This was referenced Jun 26, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what:
We currently compensate links and payment account holder when account holders were not created as a part of the workflow. The createAccountHolder is an idempotent function and that wasn't considered during compensation for the account holder step and the links creation step.
Additionally, a bug is fixed in the compensation function class where null was not being considered as a valid compensation value
FIXES CMRC-1048