Skip to content

fix(order, core-flows): Tax inclusive order line item adjustments - #12875

Merged
olivermrbl merged 5 commits into
developfrom
fix/tax-inclusive-order-adjustments
Jul 6, 2025
Merged

fix(order, core-flows): Tax inclusive order line item adjustments#12875
olivermrbl merged 5 commits into
developfrom
fix/tax-inclusive-order-adjustments

Conversation

@olivermrbl

@olivermrbl olivermrbl commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

What

Add flag is_tax_inclusive to order adjustment

Why

When we added support for tax-inclusive promotions, we were only considering it in the context of carts. This means whenever a cart would convert to an order, the discount totals calculation would be off (we're still charging the correct amount, because the payment was created from the cart).

@olivermrbl
olivermrbl requested a review from a team as a code owner July 2, 2025 11:09
@changeset-bot

changeset-bot Bot commented Jul 2, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c05253e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Jul 2, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jul 3, 2025 4:09pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2025 4:09pm
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 3, 2025 4:09pm
cloud-docs ⬜️ Ignored (Inspect) Visit Preview Jul 3, 2025 4:09pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jul 3, 2025 4:09pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 3, 2025 4:09pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jul 3, 2025 4:09pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jul 3, 2025 4:09pm
user-guide ⬜️ Ignored (Inspect) Visit Preview Jul 3, 2025 4:09pm

@olivermrbl

Copy link
Copy Markdown
Contributor Author

/snapshot-this

@olivermrbl

Copy link
Copy Markdown
Contributor Author

/snapshot-this

@github-actions

github-actions Bot commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/admin-bundler@2.8.7-snapshot-20250703143840
yarn add @medusajs/admin-sdk@2.8.7-snapshot-20250703143840
yarn add @medusajs/admin-shared@2.8.7-snapshot-20250703143840
yarn add @medusajs/admin-vite-plugin@2.8.7-snapshot-20250703143840
yarn add @medusajs/dashboard@2.8.7-snapshot-20250703143840
yarn add create-medusa-app@2.8.7-snapshot-20250703143840
yarn add @medusajs/cli@2.8.7-snapshot-20250703143840
yarn add medusa-dev-cli@2.8.7-snapshot-20250703143840
yarn add @medusajs/medusa-oas-cli@2.8.7-snapshot-20250703143840
yarn add @medusajs/core-flows@2.8.7-snapshot-20250703143840
yarn add @medusajs/framework@2.8.7-snapshot-20250703143840
yarn add @medusajs/js-sdk@2.8.7-snapshot-20250703143840
yarn add @medusajs/modules-sdk@2.8.7-snapshot-20250703143840
yarn add @medusajs/orchestration@2.8.7-snapshot-20250703143840
yarn add @medusajs/types@2.8.7-snapshot-20250703143840
yarn add @medusajs/utils@2.8.7-snapshot-20250703143840
yarn add @medusajs/workflows-sdk@2.8.7-snapshot-20250703143840
yarn add @medusajs/icons@2.8.7-snapshot-20250703143840
yarn add @medusajs/ui@4.0.17-snapshot-20250703143840
yarn add @medusajs/ui-preset@2.8.7-snapshot-20250703143840
yarn add @medusajs/medusa@2.8.7-snapshot-20250703143840
yarn add @medusajs/telemetry@2.8.7-snapshot-20250703143840
yarn add @medusajs/test-utils@2.8.7-snapshot-20250703143840
yarn add @medusajs/analytics@2.8.7-snapshot-20250703143840
yarn add @medusajs/api-key@2.8.7-snapshot-20250703143840
yarn add @medusajs/auth@2.8.7-snapshot-20250703143840
yarn add @medusajs/cache-inmemory@2.8.7-snapshot-20250703143840
yarn add @medusajs/cache-redis@2.8.7-snapshot-20250703143840
yarn add @medusajs/cart@2.8.7-snapshot-20250703143840
yarn add @medusajs/currency@2.8.7-snapshot-20250703143840
yarn add @medusajs/customer@2.8.7-snapshot-20250703143840
yarn add @medusajs/event-bus-local@2.8.7-snapshot-20250703143840
yarn add @medusajs/event-bus-redis@2.8.7-snapshot-20250703143840
yarn add @medusajs/file@2.8.7-snapshot-20250703143840
yarn add @medusajs/fulfillment@2.8.7-snapshot-20250703143840
yarn add @medusajs/index@2.8.7-snapshot-20250703143840
yarn add @medusajs/inventory@2.8.7-snapshot-20250703143840
yarn add @medusajs/link-modules@2.8.7-snapshot-20250703143840
yarn add @medusajs/locking@2.8.7-snapshot-20250703143840
yarn add @medusajs/notification@2.8.7-snapshot-20250703143840
yarn add @medusajs/order@2.8.7-snapshot-20250703143840
yarn add @medusajs/payment@2.8.7-snapshot-20250703143840
yarn add @medusajs/pricing@2.8.7-snapshot-20250703143840
yarn add @medusajs/product@2.8.7-snapshot-20250703143840
yarn add @medusajs/promotion@2.8.7-snapshot-20250703143840
yarn add @medusajs/analytics-local@2.8.7-snapshot-20250703143840
yarn add @medusajs/analytics-posthog@2.8.7-snapshot-20250703143840
yarn add @medusajs/auth-emailpass@2.8.7-snapshot-20250703143840
yarn add @medusajs/auth-github@2.8.7-snapshot-20250703143840
yarn add @medusajs/auth-google@2.8.7-snapshot-20250703143840
yarn add @medusajs/file-local@2.8.7-snapshot-20250703143840
yarn add @medusajs/file-s3@2.8.7-snapshot-20250703143840
yarn add @medusajs/fulfillment-manual@2.8.7-snapshot-20250703143840
yarn add @medusajs/locking-postgres@2.8.7-snapshot-20250703143840
yarn add @medusajs/locking-redis@2.8.7-snapshot-20250703143840
yarn add @medusajs/notification-local@2.8.7-snapshot-20250703143840
yarn add @medusajs/notification-sendgrid@2.8.7-snapshot-20250703143840
yarn add @medusajs/payment-stripe@2.8.7-snapshot-20250703143840
yarn add @medusajs/region@2.8.7-snapshot-20250703143840
yarn add @medusajs/sales-channel@2.8.7-snapshot-20250703143840
yarn add @medusajs/stock-location@2.8.7-snapshot-20250703143840
yarn add @medusajs/store@2.8.7-snapshot-20250703143840
yarn add @medusajs/tax@2.8.7-snapshot-20250703143840
yarn add @medusajs/user@2.8.7-snapshot-20250703143840
yarn add @medusajs/workflow-engine-inmemory@2.8.7-snapshot-20250703143840
yarn add @medusajs/workflow-engine-redis@2.8.7-snapshot-20250703143840

Latest commit: 779ed01

@olivermrbl
olivermrbl merged commit a7700f1 into develop Jul 6, 2025
26 checks passed
@olivermrbl
olivermrbl deleted the fix/tax-inclusive-order-adjustments branch July 6, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants