Skip to content

feat(core-flows,dashboard,js-sdk, medusa,types,utils): support notification preferences for order edits - #16238

Merged
NicolasGorga merged 3 commits into
developfrom
feat/order-edit-notification
Aug 6, 2026
Merged

feat(core-flows,dashboard,js-sdk, medusa,types,utils): support notification preferences for order edits#16238
NicolasGorga merged 3 commits into
developfrom
feat/order-edit-notification

Conversation

@shahednasser

Copy link
Copy Markdown
Member

In the order edit form, we had an input to configure whether to send a notification, but it wasn't actually being set or passed anywhere. We had a TODO to wire it up.

This PR adds support for order edit notification preferences:

  1. Add no_notification property to the OrderChange data model
  2. Allow passing no_notification in the API route and workflow for requesting order edit.
  3. Save no_notification on the order change and emit it in the request event
  4. Read no_notification in the confirmation workflow and emit it in the confirmation event
  5. Wire up the dashboard to support configuring of order edit notification

Breaking change

This PR has a breaking change on the JS SDK's sdk.admin.orderEdit.request. It now accepts the body as a request parameter, making query the third, and headers 4th.

Closes DX-2829

@shahednasser
shahednasser requested review from a team as code owners July 29, 2026 16:08
@changeset-bot

changeset-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 881b6c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 79 packages
Name Type
@medusajs/core-flows Major
@medusajs/dashboard Major
@medusajs/js-sdk Major
@medusajs/medusa Major
@medusajs/order Major
@medusajs/types Major
@medusajs/utils Major
@medusajs/test-utils Major
integration-tests-http Patch
@medusajs/draft-order Major
@medusajs/loyalty-plugin Major
@medusajs/admin-bundler Major
@medusajs/medusa-oas-cli Major
@medusajs/event-bus-redis Major
@medusajs/framework Major
@medusajs/modules-sdk Major
@medusajs/orchestration Major
@medusajs/query Major
@medusajs/workflows-sdk Major
@medusajs/cli Major
@medusajs/analytics Major
@medusajs/api-key Major
@medusajs/auth Major
@medusajs/caching Major
@medusajs/cart Major
@medusajs/currency Major
@medusajs/customer Major
@medusajs/file Major
@medusajs/fulfillment Major
@medusajs/index Major
@medusajs/inventory Major
@medusajs/link-modules Major
@medusajs/locking Major
@medusajs/notification Major
@medusajs/payment Major
@medusajs/pricing Major
@medusajs/product Major
@medusajs/promotion Major
@medusajs/rbac Major
@medusajs/region Major
@medusajs/sales-channel Major
@medusajs/settings Major
@medusajs/stock-location Major
@medusajs/store Major
@medusajs/tax Major
@medusajs/translation Major
@medusajs/user Major
@medusajs/workflow-engine-inmemory Major
@medusajs/workflow-engine-redis Major
@medusajs/oas-github-ci Major
@medusajs/cache-inmemory Major
@medusajs/cache-redis Major
@medusajs/event-bus-local Major
@medusajs/analytics-local Major
@medusajs/analytics-posthog Major
@medusajs/auth-emailpass Major
@medusajs/auth-github Major
@medusajs/auth-google Major
@medusajs/caching-redis Major
@medusajs/file-local Major
@medusajs/file-s3 Major
@medusajs/fulfillment-manual Major
@medusajs/locking-postgres Major
@medusajs/locking-redis Major
@medusajs/notification-local Major
@medusajs/notification-sendgrid Major
@medusajs/payment-stripe Major
@medusajs/http-types-generator Major
@medusajs/deps Major
@medusajs/eslint-plugin Major
@medusajs/telemetry Major
@medusajs/admin-sdk Major
@medusajs/admin-shared Major
@medusajs/admin-vite-plugin Major
@medusajs/icons Major
@medusajs/toolbox Major
@medusajs/ui-preset Major
create-medusa-app Major
@medusajs/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@medusa-os-bot

medusa-os-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

Thanks for the contribution! Initial automated review looks good.

Team-member PR wiring the order-edit notification preference end-to-end. Adds a nullable boolean column to the order_change table (migration included), validates the new field via Zod in the request route, stores it on the order change, and emits it in both the requested and confirmed events. Dashboard UI toggle is now correctly plumbed. Integration test covers the full flow. JS-SDK breaking change (parameter-order) is correctly marked minor in the changeset. No security, performance, or correctness issues found.

Triggered by: manual workflow dispatch

@NicolasGorga NicolasGorga left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NicolasGorga
NicolasGorga merged commit 18e02fb into develop Aug 6, 2026
35 checks passed
@NicolasGorga
NicolasGorga deleted the feat/order-edit-notification branch August 6, 2026 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants